You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/11 00:28:21 UTC
[GitHub] [geode] gesterzhou commented on a diff in pull request #7670: [Don't review]: GEODE-10290: GII requester should remove departed members
gesterzhou commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869774427
##########
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##########
@@ -1077,7 +1081,8 @@ protected Set<Object> processReceivedRVV(RegionVersionVector remoteRVV,
if (id == null) {
id = myId;
}
- if (!remoteRVV.contains(id, stamp.getRegionVersion())) {
+ foundIds.add(id);
Review Comment:
it won't hurt to add id into foundIds. I will keep it the same as GII provider part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org