You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2019/12/13 15:04:45 UTC
[httpcomponents-core] 01/02: Fix `SETTINGS_HEADER_TABLE_SIZE`
implementation
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch development
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit 7fcfe9ee4a450bb5e7c6cbc145949c780c9d47e8
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Fri Dec 13 11:29:44 2019 +0100
Fix `SETTINGS_HEADER_TABLE_SIZE` implementation
---
.../src/main/java/org/apache/hc/core5/http2/config/H2Config.java | 2 +-
.../apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
index b1fce82..efea955 100644
--- a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
+++ b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
@@ -122,7 +122,7 @@ public class H2Config {
.setMaxConcurrentStreams(Integer.MAX_VALUE) // no limit
.setMaxFrameSize(INIT_MAX_FRAME_SIZE)
.setInitialWindowSize(INIT_WINDOW_SIZE)
- .setHeaderTableSize(Integer.MAX_VALUE); // unlimited
+ .setMaxHeaderListSize(Integer.MAX_VALUE); // unlimited
}
public static H2Config.Builder copy(final H2Config config) {
diff --git a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
index a6c28c9..0b55c1d 100644
--- a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
+++ b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
@@ -1188,7 +1188,7 @@ abstract class AbstractH2StreamMultiplexer implements Identifiable, HttpConnecti
private void applyRemoteSettings(final H2Config config) throws H2ConnectionException {
remoteConfig = config;
- hPackDecoder.setMaxTableSize(remoteConfig.getMaxHeaderListSize());
+ hPackEncoder.setMaxTableSize(remoteConfig.getHeaderTableSize());
final int delta = remoteConfig.getInitialWindowSize() - initOutputWinSize;
initOutputWinSize = remoteConfig.getInitialWindowSize();
@@ -1210,7 +1210,7 @@ abstract class AbstractH2StreamMultiplexer implements Identifiable, HttpConnecti
}
private void applyLocalSettings() throws H2ConnectionException {
- hPackEncoder.setMaxTableSize(localConfig.getMaxHeaderListSize());
+ hPackDecoder.setMaxTableSize(localConfig.getHeaderTableSize());
final int delta = localConfig.getInitialWindowSize() - initInputWinSize;
initInputWinSize = localConfig.getInitialWindowSize();