[jira] [Commented] (BEAM-2549) gcsio should set timeouts for http requests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070907#comment-16070907 ] 

ASF GitHub Bot commented on BEAM-2549:
--------------------------------------

GitHub user aaltay opened a pull request:

    https://github.com/apache/beam/pull/3486

    [BEAM-2549] For GCS operations use an http client with a default timeout value.

    R: @charlesccychen (cc: @sb2nov)
    
    Once this is in (and tested) we can consider removing the other timeout mechanism (thread based) we implemented for gcs reads.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/beam gcs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3486
    
----
commit 63e8fa76dd73b2ffea485d79e07dcf99449b1c56
Author: Ahmet Altay <al...@google.com>
Date:   2017-07-01T00:37:33Z

    For GCS operations use an http client with a default timeout value.

----


> gcsio should set timeouts for http requests
> -------------------------------------------
>
>                 Key: BEAM-2549
>                 URL: https://issues.apache.org/jira/browse/BEAM-2549
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Ahmet Altay
>             Fix For: 2.1.0
>
>
> Use an http client with timeout value for apitool requests. Once this is, it is also possible to simplify gcs read operations (i.e. remove the custom solution for handling timeouts.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)