You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/11 01:26:09 UTC

[GitHub] [ratis] szetszwo commented on a diff in pull request #711: RATIS-1669. Combine shell lib folder and root jars folder

szetszwo commented on code in PR #711:
URL: https://github.com/apache/ratis/pull/711#discussion_r943024986


##########
pom.xml:
##########
@@ -398,6 +398,11 @@
         <scope>test</scope>
         <version>1.7.29</version>
       </dependency>
+      <dependency>
+        <groupId>log4j</groupId>
+        <artifactId>log4j</artifactId>
+        <version>1.2.17</version>
+      </dependency>

Review Comment:
   Please don't add log4j dependency since it is known to have security risks.  Indeed, we should not bundle in our jars.  Otherwise, our software also have security risks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org