[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

["eskabetxe (via GitHub)" <gi...@apache.org>]

eskabetxe commented on code in PR #29:
URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1149378449


##########
flink-connector-jdbc/archunit-violations/6b9ab1b0-c14d-4667-bab5-407b81fba98b:
##########
@@ -26,6 +26,12 @@ org.apache.flink.connector.jdbc.catalog.PostgresCatalogITCase does not satisfy:
 * reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
 * reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
 * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\

Review Comment:
   Adding minicluster to CrateDBCatalogITCase should solve this..
   
   for example:
   @ExtendWith(MiniClusterExtension.class) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org