You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/10 16:18:03 UTC

[GitHub] [pulsar] david-streamlio opened a new pull request #6936: Issue 6931: LocalRunner

david-streamlio opened a new pull request #6936:
URL: https://github.com/apache/pulsar/pull/6936


   <!--
   ### Contribution Checklist
     
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #6931 
   
   *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
   
   Master Issue: #<xyz>
   
   ### Motivation
   
   The LocalRunner would fail to launch a local instance of the function submitted due to a "silent" NPE.
   
   ### Modifications
   
   Removed default value assignment from the Lombok annotated class
   Moved the assignment of the same default value to the same method of the FunctionConfigUtils class that determines "sane" default values for other function configuration parameters.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) NO
     - The public API: (yes / no) NO
     - The schema: (yes / no / don't know) NO
     - The default values of configurations: (yes / no) NO
     - The wire protocol: (yes / no) NO
     - The rest endpoints: (yes / no) NO
     - The admin cli options: (yes / no) NO
     - Anything that affects deployment: (yes / no / don't know) NO
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no) NO
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why? It is a bug fix
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org