Setting Hadoop Profile automatically on JDK 11 (was Re: [VOTE] Second release candidate for HBASE 2.3.6 (RC3))

[Nick Dimiduk <nd...@gmail.com>]

On Thu, Jul 29, 2021 at 23:32 张铎(Duo Zhang) <pa...@gmail.com> wrote:

> +1 (binding)
>
> Checked sigs and sums: Matched
> Built from source(11.0.11): Passed
> Rat check: Passed
> Run small tests(11.0.11): Passed
>
> One problem is that, when building with jdk11, we will fail the build and
> let users specify -Dhadoop.profile=3.0. Maybe we could switch to 3.0
> profile automatically when building with jdk11?
>

I think this would be a nice (though maybe surprising) improvement. I gave
it a try when I was working on the JDK 11 support. I think the trouble was
that we activate the hadoop profile via build property, and there’s no way
for maven to re-evaluate properties for profile activation. You also cannot
directly activate a profile from within a profile.

I concluded that we’d need to replicate the hadoop3 profile definition in
the jdk11 profile definition. If someone can find a working alternative,
I’d be happy to test and review.

Thanks,
Nick

clara xiong <cl...@gmail.com>于2021年7月30日 周五06:38写道：
>
> > A chaos monkey test with 4.5 billion rows on a small test cluster for 20
> > hours successfully on 2.3.6RC2.
> >
> > On Thu, Jul 29, 2021 at 11:50 AM Nick Dimiduk <nd...@apache.org>
> wrote:
> >
> > > +1
> > >
> > >         * Compatibility Report: ok
> > >         * Recent test history in Jenkins: ok
> > >         * Signature: ok
> > >         * Checksum : ok
> > >         * Rat check (1.8.0_292): ok
> > >          - mvn clean apache-rat:check -D skipTests
> > >         * Rat check (11.0.11): ok
> > >          - mvn clean apache-rat:check -D skipTests -D
> hadoop.profile=3.0
> > >         * Built from source (1.8.0_292): ok
> > >          - mvn clean install -D skipTests -DskipTests
> > >         * Built from source (11.0.11): ok
> > >          - mvn clean install -D skipTests -D hadoop.profile=3.0
> > -DskipTests
> > >
> > >
> > > On Wed, Jul 28, 2021 at 7:56 PM Stack <st...@duboce.net> wrote:
> > >
> > > > Please vote on this Apache hbase release candidate,
> > > > hbase-2.3.6RC3
> > > >
> > > > The VOTE will remain open for at least 72 hours.
> > > >
> > > > [ ] +1 Release this package as Apache hbase 2.3.6
> > > > [ ] -1 Do not release this package because ...
> > > >
> > > > The tag to be voted on is 2.3.6RC3:
> > > >
> > > >   https://github.com/apache/hbase/tree/2.3.6RC3
> > > >
> > > > This tag currently points to git reference
> > > >
> > > >   7414579f2620fca6b75146c29ab2726fc4643ac9
> > > >
> > > > The release files, including signatures, digests, as well as
> CHANGES.md
> > > > and RELEASENOTES.md included in this RC can be found at:
> > > >
> > > >   https://dist.apache.org/repos/dist/dev/hbase/2.3.6RC3/
> > > >
> > > > Maven artifacts are available in a staging repository at:
> > > >
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1463/
> > > >
> > > > Artifacts were signed with the 0xA7874F29 key which can be found in:
> > > >
> > > >   https://dist.apache.org/repos/dist/release/hbase/KEYS
> > > >
> > > > To learn more about Apache hbase, please see
> > > >
> > > >   http://hbase.apache.org/
> > > >
> > > > Thanks,
> > > > Your HBase Release Manager
> > > >
> > >
> >
>