You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by mb...@apache.org on 2011/10/16 17:16:44 UTC

svn commit: r1184846 - /commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java

Author: mbenson
Date: Sun Oct 16 15:16:44 2011
New Revision: 1184846

URL: http://svn.apache.org/viewvc?rev=1184846&view=rev
Log:
clean up a synchronization bug found by FindBugs

Modified:
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java

Modified: commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java
URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java?rev=1184846&r1=1184845&r2=1184846&view=diff
==============================================================================
--- commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java (original)
+++ commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/collection/FilteredIterable.java Sun Oct 16 15:16:44 2011
@@ -50,7 +50,7 @@ public class FilteredIterable<T> impleme
          * {@inheritDoc}
          */
         @Override
-        public synchronized FilteredIterable retain(UnaryPredicate predicate) {
+        public FilteredIterable retain(UnaryPredicate predicate) {
             return this;
         }
 
@@ -85,7 +85,11 @@ public class FilteredIterable<T> impleme
      * {@inheritDoc}
      */
     public Iterator<T> iterator() {
-        return FilteredIterator.filter(iterable.iterator(), predicate);
+        UnaryPredicate<T> _predicate;
+        synchronized (this) {
+            _predicate = predicate;
+        }
+        return FilteredIterator.filter(iterable.iterator(), _predicate);
     }
 
     /**