You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by djvulee <gi...@git.apache.org> on 2017/08/28 07:10:25 UTC
[GitHub] spark pull request #19067: [SPARK-21849][Core]Make the serializer function m...
GitHub user djvulee opened a pull request:
https://github.com/apache/spark/pull/19067
[SPARK-21849][Core]Make the serializer function more robust
## What changes were proposed in this pull request?
make sure the `close` function is called in the `finally` block.
## How was this patch tested?
No Test, just compile.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djvulee/spark serializer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19067.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19067
----
commit b523ecbef727df73b3b018eb851fb66981e98770
Author: DjvuLee <li...@bytedance.com>
Date: 2017-08-28T07:00:56Z
[SPARK-21849][Core]Make the serializer function more robust
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19067
**[Test build #3908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3908/testReport)** for PR 19067 at commit [`b523ecb`](https://github.com/apache/spark/commit/b523ecbef727df73b3b018eb851fb66981e98770).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19067
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19067
If this doesn't fix anything and isn't making the code better or more consistent, it should be closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19067
There is no actual resource associated with the underlying stream anyway (it's a ByteArrayOutputStream) and it's closed in the normal flow anyway. I don't object, but it's the kind of thing that's generally too trivial to spend time proposing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by djvulee <gi...@git.apache.org>.
Github user djvulee commented on the issue:
https://github.com/apache/spark/pull/19067
Yes, I agree. it is better included in a normal pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19067: [SPARK-21849][Core]Make the serializer function m...
Posted by djvulee <gi...@git.apache.org>.
Github user djvulee closed the pull request at:
https://github.com/apache/spark/pull/19067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19067: [SPARK-21849][Core]Make the serializer function more rob...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19067
**[Test build #3908 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3908/testReport)** for PR 19067 at commit [`b523ecb`](https://github.com/apache/spark/commit/b523ecbef727df73b3b018eb851fb66981e98770).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org