You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/11/15 12:39:52 UTC
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2925
[CARBONDATA-3102] Fix NoClassDefFoundError when use thriftServer and beeline
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
No
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-3102_fixBeelineThriftServerError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2925.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2925
----
commit 86201f124c8857d70d50730fa33d93cd250d6d59
Author: xubo245 <xu...@...>
Date: 2018-11-15T12:36:12Z
[CARBONDATA-3102] Fix NoClassDefFoundError when use thriftServer and beeline
----
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@xubo245 I dont think we are supporting thriftServer to be run through IntelliJ on local. In cluster mode this jar would already be available as part of spark dependency.
For SDK because it is dependent on all modules therefore httpclient is required.
@manishgupta88 @kumarvishal09 @jackylk @ravipesala What are your opinions?
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1429/
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241802106
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
ok, done
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@jackylk @KanakaKumar @kunal642 Please review it.
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241736440
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
I have never encounter this problem before, can you describe the scenario in more detail, in what case NoClassDefFoundError will be thrown?
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234191527
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
Why is this dependency needed in spark2?
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1770/
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241802156
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
@@ -48,8 +48,13 @@ object CarbonThriftServer {
System.exit(0)
}
+ val master = Option(System.getProperty("spark.master"))
--- End diff --
ok, done
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9686/
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234962295
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
@@ -48,8 +48,13 @@ object CarbonThriftServer {
System.exit(0)
}
+ val master = Option(System.getProperty("spark.master"))
--- End diff --
ok
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1423/
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
Please add description
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241774500
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
I see `org.apache.httpcomponents` is already introduced in other modules, please unify the version for this jar in all places
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@kunal642 @jackylk Please review it.
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234982825
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
I meet more than two times. This issue also happen in spark on k8s before. You can try in original cluster.
It's not convenient for user to add httpclient jars to you cluster seperately. What's effect if we add this dependency?
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234191597
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
@@ -48,8 +48,13 @@ object CarbonThriftServer {
System.exit(0)
}
+ val master = Option(System.getProperty("spark.master"))
--- End diff --
Was this the reason for NoClassDefFoundError?
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1638/
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r235015512
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala ---
@@ -157,8 +157,8 @@ object S3Example {
}
def getSparkMaster(args: Array[String]): String = {
- if (args.length == 5) args(4)
- else if (args(3).contains("spark:") || args(3).contains("mesos:")) args(3)
- else "local"
- }
--- End diff --
revert the unnecessary changes
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234541941
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
@@ -48,8 +48,13 @@ object CarbonThriftServer {
System.exit(0)
}
+ val master = Option(System.getProperty("spark.master"))
--- End diff --
No, it's support CarbonThriftServer run in local/cluster, which convenient for users. Before if user want to run CarbonThriftServer in local, user need add master("local")
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1632/
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@jackylk @KanakaKumar @kunal642 Please review it.
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2925
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234541398
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
Because when I use org.apache.carbondata.spark.thriftserver.CarbonThriftServe and use beeline to connect, it throw NoClassDefFoundError。NoClassDefFoundError: org/apache/http/impl/conn/PoolingClientConnectionManager。 PoolingClientConnectionManager is belong to httpclient, so I add:
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>${httpclient.version}</version>
</dependency>
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r235027703
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala ---
@@ -157,8 +157,8 @@ object S3Example {
}
def getSparkMaster(args: Array[String]): String = {
- if (args.length == 5) args(4)
- else if (args(3).contains("spark:") || args(3).contains("mesos:")) args(3)
- else "local"
- }
--- End diff --
the format is incorrect. we should optimize it.
```def getS3EndPoint(args: Array[String]): String = { def getS3EndPoint(args: Array[String]): String = {
if (args.length >= 4 && args(3).contains(".com")) args(3) if (args.length >= 4 && args(3).contains(".com")) args(3)
else "" else ""
}```
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10030/
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@kunal642 In cluster, it also has this problem.
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241736214
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
@@ -48,8 +48,13 @@ object CarbonThriftServer {
System.exit(0)
}
+ val master = Option(System.getProperty("spark.master"))
--- End diff --
I think better to let user give --master local, user can control this.
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@xubo245 I what scenario are you facing this issue? I am not facing this issue.
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2925
LGTM
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9680/
---
[GitHub] carbondata issue #2925: [CARBONDATA-3102] Fix NoClassDefFoundError when use ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2925
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1983/
---
[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234962085
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
--- End diff --
But nobody else is facing this issue. And also none of our environments are getting this exception. Maybe u need to add httpclient jars to you cluster seperately?
---