[GitHub] spark pull request: [SPARK-7770] [ML] GBT validationTol change to ...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8549#discussion_r40984204
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
    @@ -250,7 +250,8 @@ object GradientBoostedTrees extends Logging {
           predError = GradientBoostedTreesModel.updatePredictionError(
             input, predError, baseLearnerWeights(m), baseLearners(m), loss)
           predErrorCheckpointer.update(predError)
    -      logDebug("error of gbt = " + predError.values.mean())
    +      val currentPredError = predError.values.mean()
    --- End diff --
    
    Since this is only used in logDebug, it would be better to put it inside logDebug so that it is not computed if debug logging is turned off.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org