[GitHub] [incubator-kyuubi] zhaomin1423 commented on a diff in pull request #2259: [KYUUBI #2257] Replace replace conf vars with strings in HiveSQLEngine

[GitBox <gi...@apache.org>]

zhaomin1423 commented on code in PR #2259:
URL: https://github.com/apache/incubator-kyuubi/pull/2259#discussion_r850019342


##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala:
##########
@@ -77,10 +77,10 @@ object HiveSQLEngine extends Logging {
       (msConnUrl != null && msConnUrl.startsWith("jdbc:derby"))
     }
     if (isEmbeddedMetaStore) {
-      hiveConf.setBoolean("hive.metastore.schema.verification", false)
-      hiveConf.setBoolean("datanucleus.schema.autoCreateAll", true)
+      hiveConf.setBoolean(ConfVars.METASTORE_SCHEMA_VERIFICATION.varname, false)
+      hiveConf.setBoolean(ConfVars.METASTORE_AUTO_CREATE_ALL.varname, true)
       hiveConf.set(
-        "hive.metastore.warehouse.dir",
+        ConfVars.METASTOREWAREHOUSE.varname,

Review Comment:
   Thanks, I have been replaced conf vars with strings, they are marked as deprecated in hive-3.1.3.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org