You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ted Zlatanov (JIRA)" <ji...@apache.org> on 2010/01/26 15:56:35 UTC

[jira] Created: (CASSANDRA-743) configuration should support includes

configuration should support includes
-------------------------------------

                 Key: CASSANDRA-743
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
             Project: Cassandra
          Issue Type: Wish
          Components: Core
            Reporter: Ted Zlatanov
            Priority: Minor


I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-743) configuration should support includes

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-743:
-------------------------------------

    Fix Version/s: 0.7

I don't see any benefit to applying this before we decide what configuration is going to look like in 0.7 (see CASSANDRA-671).  Moving to 0.7 version.

> configuration should support includes
> -------------------------------------
>
>                 Key: CASSANDRA-743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 001-CASSANDRA-743-confsplit.patch
>
>
> I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-743) configuration should support includes

Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806338#action_12806338 ] 

Ted Zlatanov commented on CASSANDRA-743:
----------------------------------------

Here's the original context: http://thread.gmane.org/gmane.comp.db.cassandra.devel/557/focus=571

Given two machines with identical storage-conf.xml except for directories, for example, currently you need two separate storage-conf.xml files with 99% identical contents.  This quickly becomes painful if other parameters vary slightly, too.  You can see Anthony Molinaro's situation and mine is very similar.

This patch refactors storage-conf.xml to be a single top configuration file with included configuration sections for seeds, tuning, directories, and networking.  It all uses XML facilities (as recommended by the XML FAQ at http://xml.silmaril.ie/authors/includes) so no code changes are required.

As I said, it doesn't have to go into SVN (although I think it improves the current monolithic XML file a bit).  It can just go on the wiki as a suggestion, which I'll do at http://wiki.apache.org/cassandra/StorageConfiguration if you reject the patch.

> configuration should support includes
> -------------------------------------
>
>                 Key: CASSANDRA-743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 001-CASSANDRA-743-confsplit.patch
>
>
> I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-743) configuration should support includes

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806221#action_12806221 ] 

Jonathan Ellis commented on CASSANDRA-743:
------------------------------------------

What problem is this solving?

> configuration should support includes
> -------------------------------------
>
>                 Key: CASSANDRA-743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 001-CASSANDRA-743-confsplit.patch
>
>
> I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-743) configuration should support includes

Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828126#action_12828126 ] 

Ted Zlatanov commented on CASSANDRA-743:
----------------------------------------

Can someone please accept or reject this patch so I know if I should put it on the wiki?  Thanks.

> configuration should support includes
> -------------------------------------
>
>                 Key: CASSANDRA-743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 001-CASSANDRA-743-confsplit.patch
>
>
> I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-743) configuration should support includes

Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Zlatanov updated CASSANDRA-743:
-----------------------------------

    Attachment: 001-CASSANDRA-743-confsplit.patch

This patch demonstrates how to split up the config files using just built-in XML facilities.  No code changes.  I split it up in a way that makes sense to me but it's certainly not the only way to go.  Explicitly validated external includes are probably not worth it if the XML config backend is going away.  If this patch doesn't go into SVN, perhaps the wiki should be updated to show it.

> configuration should support includes
> -------------------------------------
>
>                 Key: CASSANDRA-743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-743
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 001-CASSANDRA-743-confsplit.patch
>
>
> I hope to get includes working (as discussed on the dev mailing list in November 2009) so Cassandra configs can be split into a generic and a machine-specific piece.  That would make deployments easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.