You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Vladimir Sitnikov (JIRA)" <ji...@apache.org> on 2018/08/20 08:07:00 UTC

[jira] [Resolved] (CALCITE-2462) RexProgramTest: move "rex building" methods to base class

     [ https://issues.apache.org/jira/browse/CALCITE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov resolved CALCITE-2462.
----------------------------------------
    Resolution: Fixed

> RexProgramTest: move "rex building" methods to base class
> ---------------------------------------------------------
>
>                 Key: CALCITE-2462
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2462
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> RexProgramTest is quite big (2000 lines now), and "easy to use" rex building is useful for many tests.
> So I suggest to move methods like {{gt}}, {{lt}}, etc to the base class, so multiple other tests can reuse it.
> Alternative option would be to use Kotlin for builders, yet I think Java tests will be there for quite a while, so it would be nice to simplify them as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)