[jira] [Commented] (AVRO-2161) Upgrade C# Unit Tests to NUnit 3.x

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741232#comment-16741232 ] 

ASF subversion and git services commented on AVRO-2161:
-------------------------------------------------------

Commit 9a05375436385b7fce75d32cfdcd359e279e0628 in avro's branch refs/heads/master from Brian Lachniet
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=9a05375 ]

AVRO-2112: Target .NET Standard/Core in C# (#307)

* AVRO-2161: Upgrade C# unit tests to NUnit 3

* AVRO-2112: Update C# projects to target .NET Standard/Core and .NET Framework 4.0

* AVRO-2112: Move C# IPC tests to a Avro.ipc.test

* AVRO-2112: Ignore C# tests that use System.CodeDom compilation when targeting .NET Core

See https://github.com/dotnet/corefx/issues/12180

* AVRO-2112: Replace usage of JToken.ToString() in C# projects

In Newtonsoft.Json v3.5, JToken.ToString() returned the raw JSON
representation of the token. In later versions of
Newtonsoft.Json, JToken.ToString() returns a simple string
representation of the value. See the examples below:
- v3.5: "\"Hello World\""
- Later versions: "Hello World"

In this commit, I've updated the project to work with later versions
of Newtonsoft.Json as well as v3.5. I've replaced some usages of
JToken.ToString(). When we need the raw JSON representation, we use
JsonConvert.Serialize(). When we need the string value of a string
JToken, we use JToken.Value<string>().

* AVRO-2112: Update C# README

* Update pom.xml with new C# paths to ignore for license check

* csharp: Cut support for net35, update Dockerfile and csharp build.sh

* Add mono-complete to Dockerfile for build

* csharp: Remove unnecessary ProjectGuid elements from projects

* Revert to only running tests for Avro.test.dll

This is what we were doing on master. I was trying to run the IPC tests,
but that has not seemed to work well in our automated builds.

* List all tests as they are run

* Add build.ps1 and update README

* Update Target Frameworks table in README

* Try disabling tests that take a long time to run


> Upgrade C# Unit Tests to NUnit 3.x
> ----------------------------------
>
>                 Key: AVRO-2161
>                 URL: https://issues.apache.org/jira/browse/AVRO-2161
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.8.2
>            Reporter: Brian Lachniet
>            Priority: Major
>
> Before we can upgrade the C# project to .NET Core (AVRO-2112), we must first upgrade our dependencies to versions that also run on .NET Core. NUnit is one of the dependencies that we must upgrade.
> NUnit 3.x will [run on .NET Core|https://github.com/nunit/docs/wiki/.NET-Core-and-.NET-Standard]. There many changes we must make in the [migration from NUnit 2.x to 3.x|https://github.com/nunit/docs/wiki/Breaking-Changes#nunit-30].
> Since this is more than a simple update to a new version of the library, I believe we should tackle this separate from other big migration tasks, like the migration to .NET Core.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)