[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1553:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1163873063


##########
extensions/libarchive/BinFilesStaticDefinitions.cpp:
##########
@@ -34,19 +34,19 @@ const core::Property BinFiles::MinSize(
 const core::Property BinFiles::MaxSize(
     core::PropertyBuilder::createProperty("Maximum Group Size")
     ->withDescription("The maximum size for the bundle. If not specified, there is no maximum.")
-    ->withType(core::StandardValidators::get().UNSIGNED_LONG_VALIDATOR)->build());
+    ->withType(gsl::make_not_null(&core::StandardValidators::UNSIGNED_LONG_VALIDATOR))->build());

Review Comment:
   Yes, that makes the calling site much cleaner.  Fixed in 4648366b31e3f1f1d049e0a9a636dc53791105bb.
   
   I have also changed the constructor of `ConfigurationProperty` in 726fa89d2a54c3918d8936a20765c9e6bb46c454, although we may have to undo that when resolving the conflict with #1543.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org