[GitHub] [arrow] xxlaykxx commented on a diff in pull request #36434: GH-36433: [C++] Update fast_float version

["xxlaykxx (via GitHub)" <gi...@apache.org>]

xxlaykxx commented on code in PR #36434:
URL: https://github.com/apache/arrow/pull/36434#discussion_r1252560820


##########
cpp/src/arrow/vendored/fast_float/README.md:
##########
@@ -20,7 +20,7 @@
 # fast_float
 
 The files in this directory are vendored from fast_float
-git tag `v3.8.1`.
+git tag `v3.10.1`.

Review Comment:
   after 3.10.1 they started using c++ 20 and it cause a lot of build errors. In reality - we just need in parse_number.h 
   ```
   #ifdef FASTFLOAT_ALLOWS_LEADING_PLUS // disabled by default
     if (*first == UC('+')) {
         ++first;
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org