You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/13 06:29:04 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #12027: fix:
fix candlestick throw error when some series filtered by legend.
100pah opened a new pull request #12027: fix: fix candlestick throw error when some series filtered by legend.
URL: https://github.com/apache/incubator-echarts/pull/12027
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix candlestick throw error when some series filtered by legend.
### Fixed issues
fix #11611
## Details
### Before: What was the problem?
Throw error. see the case in #11611 .
### After: How is it fixed in this PR?
Fix it by null checking.
But it might not be a best way.
If intending to declare `performRawSeries` in handlers, only
stream-independent (specifically, data item independent) operations can be
performed. Because is a series is filtered, most of the tasks will not
be performed. A stream-dependent operation probably cause wrong biz logic.
Perhaps we should not provide a separate callback for this case instead
of providing the config `performRawSeries`. The stream-dependent operations
and stream-independent operations should better not be mixed.
It can be down in future version because some more tests and check are needed,
now that the deadline of 4.7.0 is coming.
### Related test cases or examples to use the new APIs
`test/stream-filter2.html`.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12027: fix: fix
candlestick throw error when some series filtered by legend.
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12027: fix: fix candlestick throw error when some series filtered by legend.
URL: https://github.com/apache/incubator-echarts/pull/12027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org