You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/12/03 20:11:58 UTC
[jira] [Created] (HBASE-7262) Move HBaseRPC metrics to metrics2
Elliott Clark created HBASE-7262:
------------------------------------
Summary: Move HBaseRPC metrics to metrics2
Key: HBASE-7262
URL: https://issues.apache.org/jira/browse/HBASE-7262
Project: HBase
Issue Type: Sub-task
Components: metrics
Affects Versions: 0.96.0
Reporter: Elliott Clark
Priority: Blocker
HBase RPC is the last thing still publishing through metrics1. We should move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7262) Move HBaseRPC metrics to metrics2
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510294#comment-13510294 ]
stack commented on HBASE-7262:
------------------------------
bq. removed when calls are above 1 second. That should be in HRegionServer's metrics as it will allow things to be much much faster (less looking things up by method name in a hashmap).
Is this a TODO?
On the patch...
MetricsHBaseServerSource missing license
... a few classes in here missing license
Should fix this kinda stuff:
+ assertNotNull("Should get gauge "+cName + " but did not",gauges.get(cName));
We put space after ',' and around operators like '+'
I like stuff like the below:
- public HBaseRpcMetrics getRpcMetrics() {
- return rpcServer.getRpcMetrics();
- }
Patch looking good.
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
> Key: HBASE-7262
> URL: https://issues.apache.org/jira/browse/HBASE-7262
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-7262-0.patch
>
>
> HBase RPC is the last thing still publishing through metrics1. We should move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7262) Move HBaseRPC metrics to metrics2
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7262:
---------------------------------
Attachment: HBASE-7262-0.patch
* Move HBaseRPCMetrics -> MetricsHBaseServer
* Moved all metrics to metrics 2.
* removed when calls are above 1 second. That should be in HRegionServer's metrics as it will allow things to be much much faster (less looking things up by method name in a hashmap).
* Added tests for wrapper
* Added a test for incrementing the counters.
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
> Key: HBASE-7262
> URL: https://issues.apache.org/jira/browse/HBASE-7262
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-7262-0.patch
>
>
> HBase RPC is the last thing still publishing through metrics1. We should move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7262) Move HBaseRPC metrics to metrics2
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510336#comment-13510336 ]
Elliott Clark commented on HBASE-7262:
--------------------------------------
bq.Is this a TODO?
Yeah I was just hoping that Jenkins would be back to run the test suite, so I could know if things worked on both Hadoop versions. But seems like Jenkins is not coming back soon. So I'll just run all the large tests tomorrow when I get in.
bq.MetricsHBaseServerSource missing license
Yeah sorry I should have explained better I was just trying to post what I got done in the hackathon.
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
> Key: HBASE-7262
> URL: https://issues.apache.org/jira/browse/HBASE-7262
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-7262-0.patch
>
>
> HBase RPC is the last thing still publishing through metrics1. We should move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7262) Move HBaseRPC metrics to metrics2
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark reassigned HBASE-7262:
------------------------------------
Assignee: Elliott Clark
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
> Key: HBASE-7262
> URL: https://issues.apache.org/jira/browse/HBASE-7262
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
>
> HBase RPC is the last thing still publishing through metrics1. We should move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira