[GitHub] [activemq] cshannon commented on a diff in pull request #1005: [AMQ-9257] Disabled expire message checking when pauseDispatch=true

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #1005:
URL: https://github.com/apache/activemq/pull/1005#discussion_r1196514572


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -957,6 +957,11 @@ private void checkUsage(ConnectionContext context,ProducerBrokerExchange produce
     }
 
     private void expireMessages() {
+        if(isDispatchPaused()) {

Review Comment:
   This is not threadsafe, this is usually accessed when protected by the consumers lock and the variable isn't volatile. I don't think we want to be accessing that consumers lock from this task as who knows what other issues will come up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org