You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/30 02:50:37 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

jinxing64 commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r340410648
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/SortRemoveConstantKeysRule.java
 ##########
 @@ -44,7 +45,7 @@
 
   private SortRemoveConstantKeysRule() {
 
 Review comment:
   Thanks a lot ~
   Besides all rules in existing change (FilterProjectTransposeRule, ProjectMergeRule, SortRemoveConstantKeyRule), shall we include more rules, which only need to be applied for logical nodes ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services