You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/06/27 11:42:52 UTC
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/26
[WIP] entity tags support, including REST API (but not GUI)
structure is about right but tests not yet passing. for review only.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn entity-tags
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 123844969b90aadeedfff60a051553104f0d96b4
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-06-27T09:32:33Z
[WIP] entity tags support, including REST API (but not GUI)
structure is about right but tests not yet passing. for review only.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: entity tags support, including RE...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#issuecomment-47333804
Thanks to have the test fixed. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#issuecomment-47327821
very minor comments, lgtm +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: entity tags support, including RE...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#issuecomment-47333523
fixed tests, also discovered entitlements test failure and included fix for it
ready to merge i think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#discussion_r14286558
--- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/EntityResource.java ---
@@ -83,6 +89,12 @@ public TaskSummary getTask(final String application, final String entityToken, S
}
@Override
+ public List<Object> listTags(String applicationId, String entityId) {
--- End diff --
do we need to protect this call also with EntitlementManager, maybe not in thin PR, though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#discussion_r14286581
--- Diff: usage/rest-server/src/test/java/brooklyn/rest/resources/EntityResourceTest.java ---
@@ -0,0 +1,138 @@
+/*
+ * Copyright 2014 by Cloudsoft Corporation Limited
--- End diff --
not sure we need to have this Copyright, @aledsage and @richardcloudsoft already asked me once to remove it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#discussion_r14287699
--- Diff: usage/rest-server/src/test/java/brooklyn/rest/resources/EntityResourceTest.java ---
@@ -0,0 +1,138 @@
+/*
+ * Copyright 2014 by Cloudsoft Corporation Limited
--- End diff --
agree - it was in the file i copied. have removed both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] entity tags support, includ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/26#discussion_r14287702
--- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/EntityResource.java ---
@@ -83,6 +89,12 @@ public TaskSummary getTask(final String application, final String entityToken, S
}
@Override
+ public List<Object> listTags(String applicationId, String entityId) {
--- End diff --
many methods in this class will need that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: entity tags support, including RE...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---