You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/06/26 03:51:54 UTC
[GitHub] [ratis-thirdparty] tisonkun opened a new pull request, #35: RATIS-1600. Add protobuf-java-util
tisonkun opened a new pull request, #35:
URL: https://github.com/apache/ratis-thirdparty/pull/35
Signed-off-by: tison <wa...@gmail.com>
cc @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo commented on a diff in pull request #35: RATIS-1600. Add protobuf-java-util
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #35:
URL: https://github.com/apache/ratis-thirdparty/pull/35#discussion_r907550573
##########
misc/pom.xml:
##########
@@ -17,7 +17,7 @@
<parent>
<groupId>org.apache.ratis</groupId>
<artifactId>ratis-thirdparty</artifactId>
- <version>1.0.1</version>
+ <version>1.1.0-SNAPSHOT</version>
Review Comment:
@tisonkun , thanks a lot for working on this! Please don't change the version. We will let the release managers to change it. The change looks good other than that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] tisonkun commented on a diff in pull request #35: RATIS-1600. Add protobuf-java-util
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #35:
URL: https://github.com/apache/ratis-thirdparty/pull/35#discussion_r907977622
##########
misc/pom.xml:
##########
@@ -17,7 +17,7 @@
<parent>
<groupId>org.apache.ratis</groupId>
<artifactId>ratis-thirdparty</artifactId>
- <version>1.0.1</version>
+ <version>1.1.0-SNAPSHOT</version>
Review Comment:
@szetszwo OK. Updated. Please give it another pass :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] tisonkun commented on a diff in pull request #35: RATIS-1600. Add protobuf-java-util
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #35:
URL: https://github.com/apache/ratis-thirdparty/pull/35#discussion_r906751304
##########
misc/pom.xml:
##########
@@ -17,7 +17,7 @@
<parent>
<groupId>org.apache.ratis</groupId>
<artifactId>ratis-thirdparty</artifactId>
- <version>1.0.1</version>
+ <version>1.1.0-SNAPSHOT</version>
Review Comment:
Bump version to verify locally. I'm unsure whether it's proper to be included in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo merged pull request #35: RATIS-1600. Add protobuf-java-util
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #35:
URL: https://github.com/apache/ratis-thirdparty/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org