You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Neeru Gupta <gu...@us.ibm.com> on 2016/04/14 04:15:58 UTC
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 14, 2016, 2:15 a.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs
-----
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
> On April 15, 2016, 4:45 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 336
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line336>
> >
> > Can you pls follow sql syntax for [asc, desc] - similiar to https://msdn.microsoft.com/en-us/library/ms188385.aspx . Would be familiar with users. Also ASC could be made optional
Looks like this is already taken care of in parsing. So dropping this
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129145
-----------------------------------------------------------
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:11 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129145
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/Expressions.scala (line 336)
<https://reviews.apache.org/r/45499/#comment192605>
Can you pls follow sql syntax for [asc, desc] - similiar to https://msdn.microsoft.com/en-us/library/ms188385.aspx . Would be familiar with users. Also ASC could be made optional
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:11 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129150
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala (line 386)
<https://reviews.apache.org/r/45499/#comment192609>
we would also need to take care of limit and order by in withPath expressions
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:11 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line333>
> >
> > pls add to documentaion in search.twiki
>
> Neeru Gupta wrote:
> Which wiki page is that? How do I get access to that?
its in the docs module in ATLAS code base
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129153
-----------------------------------------------------------
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:14 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line333>
> >
> > pls add to documentaion in search.twiki
Which wiki page is that? How do I get access to that?
- Neeru
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129153
-----------------------------------------------------------
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:14 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129153
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/Expressions.scala (line 333)
<https://reviews.apache.org/r/45499/#comment192612>
pls add to documentaion in search.twiki
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:11 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129154
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala (line 347)
<https://reviews.apache.org/r/45499/#comment192616>
this var could be renamed from count to something else since its a bit confusing..since its the end offset if I am correct?
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:11 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129772
-----------------------------------------------------------
docs/src/site/twiki/Search.twiki (line 25)
<https://reviews.apache.org/r/45499/#comment193319>
can you pls change asce to sortOrder
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 1:46 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129769
-----------------------------------------------------------
docs/src/site/twiki/Search.twiki (line 90)
<https://reviews.apache.org/r/45499/#comment193311>
Why is it necessary to use in backquote. Didnt understand that part?
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 1:46 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review130975
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On April 23, 2016, 12:53 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 12:53 p.m.)
>
>
> Review request for atlas and Suma Shivaprasad.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 28, 2016, 8:55 p.m.)
Review request for atlas and Suma Shivaprasad.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 06ac492d2c27d2258e65b3423e693728721ec48f
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 23, 2016, 12:53 p.m.)
Review request for atlas and Suma Shivaprasad.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review130247
-----------------------------------------------------------
docs/src/site/twiki/Search.twiki (line 31)
<https://reviews.apache.org/r/45499/#comment193970>
should be sortOrder
- Suma Shivaprasad
On April 20, 2016, 9:22 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 9:22 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 20, 2016, 9:22 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129773
-----------------------------------------------------------
docs/src/site/twiki/Search.twiki (line 29)
<https://reviews.apache.org/r/45499/#comment193321>
pls change ofset to offsetValue
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 1:46 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 20, 2016, 1:46 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Changes
-------
Added documentation in search twiki. Refactored code to avoid duplicate code. Addressed other review board comments.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
docs/src/site/twiki/Search.twiki 3a1d00f0f21fa8ed70b8c5308f57049122078278
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 20, 2016, 1:01 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Changes
-------
Added test for orderby and path.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129669
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala (line 128)
<https://reviews.apache.org/r/45499/#comment193166>
Code is duplicated . Can you pls consolidate in one class?
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:14 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129670
-----------------------------------------------------------
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala (line 126)
<https://reviews.apache.org/r/45499/#comment193167>
instead of null, pls make the scala Option Some/None
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:14 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review129671
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java (line 256)
<https://reviews.apache.org/r/45499/#comment193168>
pls add one query with order by limit and withpath
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45499/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:14 p.m.)
>
>
> Review request for atlas, David Kantor and Jeff Hagelberg.
>
>
> Bugs: ATLAS-435 and ATLAS-436
> https://issues.apache.org/jira/browse/ATLAS-435
> https://issues.apache.org/jira/browse/ATLAS-436
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-435, 436 order by and limit clause in DSL
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
> repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
>
> Diff: https://reviews.apache.org/r/45499/diff/
>
>
> Testing
> -------
>
> Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
>
> Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 19, 2016, 6:14 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Changes
-------
Adderesses review comments. Removed unused flags. Added method comments.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 19, 2016, 5:46 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta
Re: Review Request 45499: ATLAS-436,
ATLAS-435 order by and limit clause for DSL queries
Posted by Neeru Gupta <gu...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/
-----------------------------------------------------------
(Updated April 14, 2016, 2:11 p.m.)
Review request for atlas, David Kantor and Jeff Hagelberg.
Bugs: ATLAS-435 and ATLAS-436
https://issues.apache.org/jira/browse/ATLAS-435
https://issues.apache.org/jira/browse/ATLAS-436
Repository: atlas
Description
-------
ATLAS-435, 436 order by and limit clause in DSL
Diffs (updated)
-----
repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce
repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01
repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b
Diff: https://reviews.apache.org/r/45499/diff/
Testing
-------
Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries.
Order by clause is limited to specifying one criterian only. Comparison is case insensitive.
Thanks,
Neeru Gupta