You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yossi Gottlieb (JIRA)" <ji...@apache.org> on 2011/09/19 14:57:09 UTC
[jira] [Created] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Extend TS API to support TSNetAccept with inbound transparency
--------------------------------------------------------------
Key: TS-961
URL: https://issues.apache.org/jira/browse/TS-961
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Yossi Gottlieb
Priority: Minor
Fix For: 3.1.1
This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "Yossi Gottlieb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yossi Gottlieb updated TS-961:
------------------------------
Attachment: (was: api_accept_transparent.diff)
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Alan M. Carroll (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195201#comment-13195201 ]
Alan M. Carroll commented on TS-961:
------------------------------------
I need to look at this again for 3.1.3. The TS-1077 changes should make this much easier. I think I will just go with TSNetTransparentAccept().
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Alan M. Carroll (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122230#comment-13122230 ]
Alan M. Carroll commented on TS-961:
------------------------------------
I don't like just appending the transparency argument. That kind of thing got us in to trouble in the internals until we switched to the NetVCOptions struct. I think we should start off on the right foot here, even if it's just one option for now. The general rule should be that where we expect more than one default argument, all the default arguments should be put in a struct and nothing in the struct can be required for the call to work. That is, for any value in the struct either it is not needed or a reasonable functional default is available to the implementation.
While it seems reasonable to me to have two flavors of the call, one without an option struct and one with, we don't want to version this every time a new option is added. But how can the implementation detect which version of the struct was passed? A common technique is to have a version or size member at the front which has this information, but that might be too ugly for us.
Another completely different alternative is to do the socket thing and have separate "open" and "accept" calls with the ability to set options via other calls between the two. Then additional options can be added without breaking any existing API.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "Yossi Gottlieb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yossi Gottlieb updated TS-961:
------------------------------
Attachment: api_accept_transparent.diff
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_accept_transparent.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120441#comment-13120441 ]
Leif Hedstrom commented on TS-961:
----------------------------------
Hmmm, this is an "interesting" problem, I'm not sure we can break the API / ABI like this in the middle of a 3.x release cycle. Two options I think
1) Say "wtf" and just break it (which is kinda evil)
2) Make a new API (which is evil in other ways ...)
I'm personally leaning towards #2 honestly.
Thoughts?
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-961:
---------------------------
Attachment: ts-port-descriptor.patch
Prototype of the TSPortDescriptor API.
typedef struct tsapi_port* TSPortDescriptor;
tsapi TSPortDescriptor TSPortDescriptorCreate(const char * descriptor);
tsapi TSReturnCode TSPortDescriptorAccept(TSPortDescriptor, TSCont);
You create a port descriptor by passing the same port configuration string that's used in records.config. Later on, we can add additional APIs to configure the port descriptor as necessary.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: api_transparency.diff, ts-port-descriptor.patch
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Alan M. Carroll (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202477#comment-13202477 ]
Alan M. Carroll commented on TS-961:
------------------------------------
That's a very interesting idea. Give it a whirl and see how it turns out.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "Yossi Gottlieb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yossi Gottlieb updated TS-961:
------------------------------
Attachment: api_transparency.diff
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-961:
-----------------------------
Fix Version/s: (was: 3.1.2)
3.1.3
Moving this out to 3.1.3, please move as necessary.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201754#comment-13201754 ]
James Peach commented on TS-961:
--------------------------------
Hey Alan,
I was thinking about this in the context of allowing a plugin to listen on a SSL port. The approach that I'm thinking of is to add a new TSPortDescriptor API. An opaque port descriptor can be created from the string (of the form that you added recently). The descriptor can then be listened on.
Something like this:
TSPortDescriptor TSPortDescriptorParse(const char *);
void TSDestroyPortDescriptor(TSPortDescriptor);
TSAction TSPortDescriptorAccept(TSPortDescriptor);
What do you think?
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-961:
-----------------------------
Fix Version/s: (was: 3.1.1)
3.1.2
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with
inbound transparency
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-961:
---------------------------
Fix Version/s: (was: 3.1.4)
3.3.0
Punt to 3.3 as per IRC.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Leif Hedstrom (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-961:
--------------------------------
Assignee: Alan M. Carroll
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268127#comment-13268127 ]
James Peach commented on TS-961:
--------------------------------
I'm going to start working on a TSPortDescriptor API. Alan, if you think that's the right way to address this need, feel free to assign to me.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept
with inbound transparency
Posted by "Yossi Gottlieb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107877#comment-13107877 ]
Yossi Gottlieb commented on TS-961:
-----------------------------------
TSNetAccept() is extended to support inbound transparency, and TSHttpConnect() is extended to complement with outbound transparency.
This patch also contains two small fixes around TSHttpConnect() and incorrect byte order and PluginVC not assigning addresses properly.
> Extend TS API to support TSNetAccept with inbound transparency
> --------------------------------------------------------------
>
> Key: TS-961
> URL: https://issues.apache.org/jira/browse/TS-961
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Yossi Gottlieb
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: api_transparency.diff
>
>
> This is required for protocol plugins to use this capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira