[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3668: Use ArrayFormatter in Cast Kernel

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3668:
URL: https://github.com/apache/arrow-rs/pull/3668#discussion_r1100506255


##########
arrow-cast/src/cast.rs:
##########
@@ -3457,86 +3247,12 @@ where
     }
 }
 
-/// Helper function to cast from `GenericBinaryArray` to `GenericStringArray`. This function performs
-/// UTF8 validation during casting. For invalid UTF8 value, it could be Null or returning `Err` depending
-/// `CastOptions`.
-fn cast_binary_to_generic_string<I, O>(

Review Comment:
   I implemented this by converting the offsets and data separately, the performance is the same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org