You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jiangjie Qin <be...@gmail.com> on 2015/06/03 22:33:18 UTC
Review Request 35023: Patch for KAFKA-2246
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35023/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2246
https://issues.apache.org/jira/browse/KAFKA-2246
Repository: kafka
Description
-------
Change UnknownTopicOrPartitionException to extends InvalidMetadataException.
Diffs
-----
clients/src/main/java/org/apache/kafka/common/errors/UnknownTopicOrPartitionException.java ec423bd01298c6c90d9a65d87ccd6ffcb8ec88d4
Diff: https://reviews.apache.org/r/35023/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 35023: Patch for KAFKA-2246
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35023/#review86757
-----------------------------------------------------------
Ship it!
We will want to revisit this as part of the changes in KIP-4 which will allow us to do explicit topic creation by the producer on unknown topic partition exceptions.
- Joel Koshy
On June 3, 2015, 8:33 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35023/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 8:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2246
> https://issues.apache.org/jira/browse/KAFKA-2246
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Change UnknownTopicOrPartitionException to extends InvalidMetadataException.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/errors/UnknownTopicOrPartitionException.java ec423bd01298c6c90d9a65d87ccd6ffcb8ec88d4
>
> Diff: https://reviews.apache.org/r/35023/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 35023: Patch for KAFKA-2246
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35023/#review86478
-----------------------------------------------------------
Ship it!
Ship It!
- Ewen Cheslack-Postava
On June 3, 2015, 8:33 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35023/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 8:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2246
> https://issues.apache.org/jira/browse/KAFKA-2246
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Change UnknownTopicOrPartitionException to extends InvalidMetadataException.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/errors/UnknownTopicOrPartitionException.java ec423bd01298c6c90d9a65d87ccd6ffcb8ec88d4
>
> Diff: https://reviews.apache.org/r/35023/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>