You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/30 19:34:31 UTC

[GitHub] merlimat commented on a change in pull request #731: End to End Encryption Support - Java client

merlimat commented on a change in pull request #731: End to End Encryption Support - Java client
URL: https://github.com/apache/incubator-pulsar/pull/731#discussion_r136163045
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -60,6 +65,12 @@ message MessageMetadata {
 	//optional sfixed64 checksum = 10;
 	// differentiate single and batch message metadata
 	optional int32 num_messages_in_batch = 11 [default = 1];
+	// Comman separated encryption key name(s) used to encrypt data key
 
 Review comment:
   If `encryption_keys` is effectively a map, the comment should no mention "comma-separated" 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services