You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/13 23:17:46 UTC

[GitHub] [cloudstack-terraform-provider] Damans227 opened a new pull request, #37: create ssh keypair data-source

Damans227 opened a new pull request, #37:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/37

   From `main.tf`:
   
   ```
   resource "cloudstack_ssh_keypair" "test-key" {
     name       = "myKey"
   
   }
   
   data "cloudstack_ssh_keypair" "my-key-pair" {
       filter {
       name = "name" 
       value = "myKey"
     }
       depends_on = [
       cloudstack_ssh_keypair.test-key
     ]
   }
   
   output "instance-output" {
     value = "${data.cloudstack_ssh_keypair.my-key-pair}"
   }
   
   ```
   
   `terraform apply` output:
   
   ```
   Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
   
   Outputs:
   
   instance-output = {
     "filter" = toset([
       {
         "name" = "name"
         "value" = "myKey"
       },
     ])
     "fingerprint" = "7b:c2:46:e2:71:50:82:2a:3a:ed:fe:84:5a:bd:b4:61"
     "id" = "myKey"
     "name" = "myKey"
   }
   ```
   
   Issue: https://github.com/apache/cloudstack/issues/6016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] Damans227 closed pull request #37: create ssh keypair data-source

Posted by GitBox <gi...@apache.org>.
Damans227 closed pull request #37: create ssh keypair data-source
URL: https://github.com/apache/cloudstack-terraform-provider/pull/37


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #37: create ssh keypair data-source

Posted by GitBox <gi...@apache.org>.
Damans227 commented on PR #37:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1155614186

   Merged this branch onto `AddInstanceDataSource`. Therefore, closing it off now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #37: create ssh keypair data-source

Posted by GitBox <gi...@apache.org>.
Damans227 commented on PR #37:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1155109051

   > Hi @Damans227, glad to see your changes.
   > 
   > I think it is better to create a single PR for all the datasources since it will be easy to identify the feature additions. Also, there will be separate files for each datasource, so reviewing it also won't be a problem.
   > 
   > May I ask you to please merge this change in your previous PR.
   
   Hi @harikrishna-patnala Thank you for your feedback. I will merge the existing PRs and add further data sources to one pull request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on pull request #37: create ssh keypair data-source

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #37:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1154821152

   Hi @Damans227, glad to see your changes.
   
   I think it is better to create a single PR for all the datasources since it will be easy to identify the feature additions. Also, there will be separate files for each datasource, so reviewing it also won't be a problem. 
   
   May I ask you to please merge this change in your previous PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org