[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464007#comment-16464007 ] 

Michael Osipov edited comment on SCM-885 at 5/4/18 3:24 PM:
------------------------------------------------------------

It is not per sé wrong:

bq. You can also leave off one side of the syntax to have Git assume HEAD. For example, you can get the same results as in the previous example by typing git log origin/master.. — Git substitutes HEAD if one side is missing.

So this will be wrong? Does it make sense to call {{...END}} at all?

Works for me:

{noformat}
osipovmi@blnn719x:~/var/krb5 (master *%>)
$ git log --date=iso ..origin/krb5-1.8 -- . | head
commit 33af1767f876ff4a13f28513dede75e71544523f
Author: Greg Hudson <gh...@mit.edu>
Date:   2012-02-21 18:57:44 +0000

    Fix kvno ASN.1 encoding interop with Windows RODCs

    RFC 4120 defines the EncryptedData kvno field as an integer in the
    range of unsigned 32-bit numbers.  Windows encodes and decodes the
    field as a signed 32-bit integer.  Historically we do the same in our
    encoder in 1.6 and prior, and in our decoder through 1.10.  (Actually,
{noformat}


was (Author: michael-o):
It is not per sé wrong:

bq. You can also leave off one side of the syntax to have Git assume HEAD. For example, you can get the same results as in the previous example by typing git log origin/master.. — Git substitutes HEAD if one side is missing.

So this will be wrong? Does it make sense to call {{...END}} at all?

> GitChangeLogCommand is wrong when only endVersion is set
> --------------------------------------------------------
>
>                 Key: SCM-885
>                 URL: https://issues.apache.org/jira/browse/SCM-885
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5
>            Reporter: Matthieu Brouillard
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.9.6
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)