[GitHub] [hbase] wchevreuil commented on a change in pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2077:
URL: https://github.com/apache/hbase/pull/2077#discussion_r458267492



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -87,8 +108,24 @@ public void stop() {
   }
 
   @Override
-  protected void doStart() {
+  protected synchronized void doStart() {
     try {
+      try (Admin admin = getPeerConnection().getAdmin()) {
+        String version = admin.getClusterMetrics().getHBaseVersion();
+        LOG.info("Peer cluster version is {} for peer {}", version, ctx.getPeerId());
+        if (Integer.parseInt(version.split("\\.")[0]) >= 3) {

Review comment:
       Would it be interesting to also add a config flag allowing 3+ versions to optionally still use ZK?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org