You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "massucattoj (via GitHub)" <gi...@apache.org> on 2026/01/26 20:25:16 UTC
[PR] fix(select): prevent bulk action buttons from being cut off in filters [superset]
massucattoj opened a new pull request, #37453:
URL: https://github.com/apache/superset/pull/37453
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Fixes the "Select all" and "Deselect all" buttons being cut off in multi-select filters, particularly when the filter bar is in horizontal orientation.
**Changes:**
- Renamed "Deselect all" button to "Clear" for brevity
- Set consistent 8px gap between the two bulk action buttons
- Added minimum dropdown width (168px) when bulk actions are enabled to ensure buttons are fully visible
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
<img width="312" height="431" alt="Screenshot 2026-01-26 at 17 24 50" src="https://github.com/user-attachments/assets/bb31e53d-c0bc-43fa-a1bc-3a8f9d2b2865" />
AFTER:
<img width="353" height="401" alt="Screenshot 2026-01-26 at 17 22 44" src="https://github.com/user-attachments/assets/ce7d19d9-6401-4389-bfaa-1295ada85ca8" />
### TESTING INSTRUCTIONS
1. Navigate to any dashboard with a multi-select filter
2. Set the filter bar orientation to **horizontal** (Settings → Filter bar orientation)
3. Click on the multi-select filter dropdown
4. Verify:
- Both "Select all (X)" and "Clear (X)" buttons are fully visible
- Buttons are on the same line with proper spacing
- Dropdown aligns properly with the input field
5. Test with vertical filter bar orientation to ensure no regression
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(select): prevent bulk action buttons from being cut off in filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37453:
URL: https://github.com/apache/superset/pull/37453#issuecomment-3801600458
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(select): prevent bulk action buttons from being cut off in filters [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz merged PR #37453:
URL: https://github.com/apache/superset/pull/37453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(select): prevent bulk action buttons from being cut off in filters [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #37453:
URL: https://github.com/apache/superset/pull/37453#issuecomment-3805229675
Hi @massucattoj!
Will it look the same in other languages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org