You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/02/10 00:15:33 UTC

[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/4485

    SPARK-4900 [MLLIB] MLlib SingularValueDecomposition ARPACK IllegalStateException

    Fix ARPACK error code mapping, at least. It's not yet clear whether the error is what we expect from ARPACK. If it isn't, not sure if that's to be treated as an MLlib or Breeze issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-4900

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4485
    
----
commit 7355aa13f73d7adf4298dd62e629e8b938b5ff0a
Author: Sean Owen <so...@cloudera.com>
Date:   2015-02-09T21:30:35Z

    Fix ARPACK error code mapping

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/4485#issuecomment-73645878
  
    LGTM. Merged into master and branch-1.3. Thanks! (Please re-open the JIRA if the issue is not fully resolved.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4485#issuecomment-73612237
  
      [Test build #27136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27136/consoleFull) for   PR 4485 at commit [`7355aa1`](https://github.com/apache/spark/commit/7355aa13f73d7adf4298dd62e629e8b938b5ff0a).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4485#issuecomment-73620985
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27136/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/4485


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-4900 [MLLIB] MLlib SingularValueDecompos...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4485#issuecomment-73620975
  
      [Test build #27136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27136/consoleFull) for   PR 4485 at commit [`7355aa1`](https://github.com/apache/spark/commit/7355aa13f73d7adf4298dd62e629e8b938b5ff0a).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `  case class MasterStateResponse(`
      * `class LocalSparkCluster(`
      * `   *   (4) the main class for the child`
      * `  case class BoundPortsResponse(actorPort: Int, webUIPort: Int, restPort: Option[Int])`
      * `      throw new SubmitRestMissingFieldException("Main class is missing.")`
      * `public class JavaLDAExample `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org