[GitHub] [pulsar] zymap commented on a change in pull request #14792: [fix] [package] Fix Auto delete the package name issue

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #14792:
URL: https://github.com/apache/pulsar/pull/14792#discussion_r834879758



##########
File path: pulsar-package-management/core/src/main/java/org/apache/pulsar/packages/management/core/impl/PackagesManagementImpl.java
##########
@@ -139,12 +139,30 @@ public void initialize(PackagesStorage storage) {
             .thenCompose(ignore -> storage.writeAsync(packagePath(packageName), inputStream));
     }
 
+    /***
+     * @see {@link PackagesManagement#delete}.
+     * At this implements, there is a problem:
+     *   Concurrently Another command: `create node` when after "getLogs" and before "deleteLog",
+     *   internal implements is recursive-delete, we could not delete every children-nodes
+     * To resolve this problem, I submit a issue&PR to bookkeeper reporitory:
+     *     https://github.com/apache/bookkeeper/issues/3132
+     *     https://github.com/apache/bookkeeper/pull/3133
+     * TODO After the PR merged, change this implements.

Review comment:
       I think that is a storage issue, not the package management core issue?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org