You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by robert burrell donkin <ro...@blueyonder.co.uk> on 2006/05/15 22:11:06 UTC

Re: [logging] Maven 2 POM(s) for commons-logging [Was: RE : [ANNOUNCEMENT] Apache Jakarta Commons Logging 1.1 Released]

On Mon, 2006-05-15 at 20:51 +0200, Dennis Lundberg wrote:
> Olivier Lamy wrote:
> > Hi,n
> > Thanks it's great job which fixes some troubles.
> > But I have a trouble concerning the pom published [1].
> > I have recorded an MEV issue [2]
> > A commons-logging developper's can put a comment or approve it ?
> > 
> > Thanks,
> > - Olivier
> > 
> > [1]
> > http://www.ibiblio.org/maven2/commons-logging/commons-logging/1.1/commons-logging-1.1.pom
> > [2] http://jira.codehaus.org/browse/MEV-392
> 
> <snip/>
> 
> I have written a comment in the JIRA issue about why the situation is 
> the way it is. 

looks good :-)

> The question is how we should proceed? Should we try to 
> tweak the POM that is currently deployed [1] 

i didn't deploy that POM and don't have karma: we'd need to talk the to
maven team.

it's too late for me to change the release POM deployed to the Apache
repository: it's cut. the easiest approach would be for one of the maven
team (who has karma) to apply appropriate modifications to the POM
version in the maven 2 repository.

> or should we try to create a POM for commons-logging-api or perhaps both?

not sure

the API works best as a virtual dependency. it can be satisfied by JCL
1.0.x, 1.1.x, by ceki's adapter or by Torsten's null implementation. not
sure whether maven 2 handles this ATM.

but the API jar contains more than is necessary for this purpose.
probably carlos is right that all the dependencies need to be marked as
optional but the full JCL jar shipped. 

not sure...

- robert



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [logging] Maven 2 POM(s) for commons-logging [Was: RE : [ANNOUNCEMENT] Apache Jakarta Commons Logging 1.1 Released]

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Tue, 2006-05-16 at 20:32 +1200, Simon Kitching wrote:
> On Mon, 2006-05-15 at 21:11 +0100, robert burrell donkin wrote:
> > > or should we try to create a POM for commons-logging-api or perhaps both?
> > 
> > not sure
> > 
> > the API works best as a virtual dependency. it can be satisfied by JCL
> > 1.0.x, 1.1.x, by ceki's adapter or by Torsten's null implementation. not
> > sure whether maven 2 handles this ATM.
> 
> Not sure what you mean by "a virtual dependency". I think the api jar
> should never be used as a dependency by anyone; it's really only for the
> use of tomcat.
> 
> If other people provide jars that define classes o.a.c.l.Log and
> LogFactory, then that can be used as a dependency *instead* of depending
> on anything from the commons-logging group. Is that what you meant?

pretty much
 
- robert



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [logging] Maven 2 POM(s) for commons-logging [Was: RE : [ANNOUNCEMENT] Apache Jakarta Commons Logging 1.1 Released]

Posted by Simon Kitching <sk...@apache.org>.
On Mon, 2006-05-15 at 21:11 +0100, robert burrell donkin wrote:
> > or should we try to create a POM for commons-logging-api or perhaps both?
> 
> not sure
> 
> the API works best as a virtual dependency. it can be satisfied by JCL
> 1.0.x, 1.1.x, by ceki's adapter or by Torsten's null implementation. not
> sure whether maven 2 handles this ATM.

Not sure what you mean by "a virtual dependency". I think the api jar
should never be used as a dependency by anyone; it's really only for the
use of tomcat.

If other people provide jars that define classes o.a.c.l.Log and
LogFactory, then that can be used as a dependency *instead* of depending
on anything from the commons-logging group. Is that what you meant?

> 
> but the API jar contains more than is necessary for this purpose.
> probably carlos is right that all the dependencies need to be marked as
> optional but the full JCL jar shipped. 
> 
> not sure...

I'd agree with this. Just mark all dependencies as optional.

I've put the same comments on the original JIRA issue:
  http://jira.codehaus.org/browse/MEV-392

Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [logging] Maven 2 POM(s) for commons-logging

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Mon, 2006-05-15 at 14:21 -0700, Carlos Sanchez wrote:
> I'm gonna tweak the poms in the repository outside of apache, 

thanks

> please add the optional property in the optional dependencies for future
> versions.

done

do we need to roll this out for all commons projects? 

> I'll take a look to the other jars to make poms.

note that the api and adapters jars are not really modules: they are
selections of the classes available in the main jar. they are used
within containers (for example, tomcat) with complex hierarchical
classloaders. whether api, adapter or full JCL should be used may depend
on the particular container the application is targeted at.

the api jar also doubles as a compilation time virtual dependency. so, a
component listing the api jar as a dependency could have this dependency
satisfied by the API jar, the full jar, ceki's bridging API, or
Torsten's null implementation.

- robert



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [logging] Maven 2 POM(s) for commons-logging [Was: RE : [ANNOUNCEMENT] Apache Jakarta Commons Logging 1.1 Released]

Posted by Carlos Sanchez <ca...@apache.org>.
I'm gonna tweak the poms in the repository outside of apache, please
add the optional property in the optional dependencies for future
versions.

I'll take a look to the other jars to make poms.

On 5/15/06, robert burrell donkin <ro...@blueyonder.co.uk> wrote:
> On Mon, 2006-05-15 at 20:51 +0200, Dennis Lundberg wrote:
> > Olivier Lamy wrote:
> > > Hi,n
> > > Thanks it's great job which fixes some troubles.
> > > But I have a trouble concerning the pom published [1].
> > > I have recorded an MEV issue [2]
> > > A commons-logging developper's can put a comment or approve it ?
> > >
> > > Thanks,
> > > - Olivier
> > >
> > > [1]
> > > http://www.ibiblio.org/maven2/commons-logging/commons-logging/1.1/commons-logging-1.1.pom
> > > [2] http://jira.codehaus.org/browse/MEV-392
> >
> > <snip/>
> >
> > I have written a comment in the JIRA issue about why the situation is
> > the way it is.
>
> looks good :-)
>
> > The question is how we should proceed? Should we try to
> > tweak the POM that is currently deployed [1]
>
> i didn't deploy that POM and don't have karma: we'd need to talk the to
> maven team.
>
> it's too late for me to change the release POM deployed to the Apache
> repository: it's cut. the easiest approach would be for one of the maven
> team (who has karma) to apply appropriate modifications to the POM
> version in the maven 2 repository.
>
> > or should we try to create a POM for commons-logging-api or perhaps both?
>
> not sure
>
> the API works best as a virtual dependency. it can be satisfied by JCL
> 1.0.x, 1.1.x, by ceki's adapter or by Torsten's null implementation. not
> sure whether maven 2 handles this ATM.
>
> but the API jar contains more than is necessary for this purpose.
> probably carlos is right that all the dependencies need to be marked as
> optional but the full JCL jar shipped.
>
> not sure...
>
> - robert
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
                             -- The Princess Bride

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org