You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:07:02 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4073: Display network name for IP in shared networks
ravening opened a new pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073
## Description
In the list publicipaddress api call ,display the network
name if ip is associated to shared network. The network
name is displayed as of now only if Ip is associated with
isolated network
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Before the patch
```
(local) 🐵 > list publicipaddresses ipaddress=10.1.1.1 listall=true forvirtualnetwork=false
{
"count": 1,
"publicipaddress": [
{
"domain": "ROOT",
"fordisplay": true,
"forvirtualnetwork": false,
"id": "eb38235f-e478-476a-bccd-bd4c95d92c8c",
"ipaddress": "10.1.1.1",
"isportable": false,
"issourcenat": false,
"isstaticnat": false,
"issystem": false,
"networkid": "791432-089-4bac-8a12-0c1efb",
"state": "Allocated",
}
]
}
```
After the patch
```
(local) 🐵 > list publicipaddresses ipaddress=10.1.1.1 listall=true forvirtualnetwork=false
{
"count": 1,
"publicipaddress": [
{
"domain": "ROOT",
"fordisplay": true,
"forvirtualnetwork": false,
"id": "eb38235f-e478-476a-bccd-bd4c95d92c8c",
"ipaddress": "10.1.1.1",
"isportable": false,
"issourcenat": false,
"isstaticnat": false,
"issystem": false,
"networkid": "7932-089-4bac-8a12-0c1eb",
"networkname": "shared-network", <<<<<<<<<<<<<<<<<<
"state": "Allocated",
}
]
}
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643531530
Strictly presentational change, full smoketests are not necessary; packaging and Travis/smoketests have passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#discussion_r436483220
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##########
@@ -150,6 +150,10 @@
@Param(description = "is public ip for display to the regular user", since = "4.4", authorized = {RoleType.Admin})
private Boolean forDisplay;
+ @SerializedName("networkname")
Review comment:
@rhtyd Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#discussion_r434953602
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##########
@@ -150,6 +150,10 @@
@Param(description = "is public ip for display to the regular user", since = "4.4", authorized = {RoleType.Admin})
private Boolean forDisplay;
+ @SerializedName("networkname")
Review comment:
@ravening can you change that to use `ApiConstants`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061185
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061449
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643078059
Packaging result: ✔centos7 ✔debian. JID-1352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org