You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by mxmrlv <gi...@git.apache.org> on 2017/05/07 13:14:41 UTC

[GitHub] incubator-ariatosca pull request #123: Dry execution changes the state of no...

GitHub user mxmrlv opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/123

    Dry execution changes the state of non implemented operations

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-214-Dry-execution-changes-the-state-of-non-implemented-operations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit 93b7983282e1c40a104caf9b023937e6bd0a9b6d
Author: max-orlov <ma...@gigaspaces.com>
Date:   2017-05-07T13:12:56Z

    wip

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #123: Dry execution changes the state of no...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-ariatosca/pull/123


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #123: Dry execution changes the state of no...

Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/123#discussion_r115145843
  
    --- Diff: aria/orchestrator/workflows/executor/base.py ---
    @@ -31,7 +31,14 @@ def execute(self, task):
             Execute a task
             :param task: task to execute
             """
    -        raise NotImplementedError
    +        if task.model_task.implementation:
    +            self._execute_empty_task(task)
    +        else:
    +            raise NotImplementedError
    --- End diff --
    
    ??
    so to implement this i have to override `execute` entirely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---