[GitHub] [iceberg] rdblue commented on a diff in pull request #4741: Add implementation for statistics information in table snapshot

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r895212082


##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -325,7 +325,7 @@ public void testAddSnapshotToJson() {
 
     Snapshot snapshot = new BaseSnapshot(null, snapshotId, parentId, System.currentTimeMillis(),
         DataOperations.REPLACE, ImmutableMap.of("files-added", "4", "files-deleted", "100"),
-        schemaId, manifests);
+        schemaId, manifests, null);

Review Comment:
   Rather than making so many changes to add `null` to tests, can you add a package-private constructor that defaults this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org