[GitHub] [incubator-streampark] zhoulii commented on a diff in pull request #2798: yarn resourceManager URL bug fix

["zhoulii (via GitHub)" <gi...@apache.org>]

zhoulii commented on code in PR #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798#discussion_r1231745768


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java:
##########
@@ -60,7 +60,7 @@ private static AlertTemplate of(Application application) {
 
     if (ExecutionMode.isYarnMode(application.getExecutionMode())) {
       String format = "%s/proxy/%s/";
-      String url = String.format(format, YarnUtils.getRMWebAppURL(), application.getAppId());
+      String url = String.format(format, YarnUtils.getRMWebAppURL(false), application.getAppId());

Review Comment:
   do we have to get dynamic url here ? if not, we can omit the false parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org