You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "lxfeng1997 (via GitHub)" <gi...@apache.org> on 2025/09/14 12:40:11 UTC
[PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
lxfeng1997 opened a new pull request, #884:
URL: https://github.com/apache/incubator-seata-go/pull/884
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "FinnTew (via GitHub)" <gi...@apache.org>.
FinnTew commented on PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#issuecomment-3313202684
The issue encountered in unit test CI:
```
../../../go/pkg/mod/go.uber.org/multierr@v1.10.0/error.go:224:20: undefined: atomic.Bool
```
This problem may be resolved by upgrading the Go version to 1.20.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "lxfeng1997 (via GitHub)" <gi...@apache.org>.
lxfeng1997 commented on code in PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#discussion_r2363014484
##########
.github/workflows/unit-test.yml:
##########
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: "Unit Test"
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ "*" ]
+ types: [opened, synchronize, reopened]
+
+permissions:
+ contents: read
+
+jobs:
+ unit-test:
+ name: Unit Test
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+ strategy:
+ matrix:
+ golang:
+ - 1.18
+
+ steps:
+ - name: "Set up Go"
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ matrix.golang }}
+
+ - name: "Checkout code"
+ uses: actions/checkout@v3
+ with:
+ submodules: true
+
+ - name: "Cache dependencies"
+ uses: actions/cache@v3
+ with:
+ path: ~/go/pkg/mod
+ key: "${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}"
+ restore-keys: |
+ "${{ runner.os }}-go-"
+
+ - name: Shutdown default mysql
+ run: sudo service mysql stop
+
+
+ - name: "Run Unit Tests"
+ run: |
+ echo "=== Starting Unit Tests ==="
+ go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic -timeout 10m
+ if [ $? -ne 0 ]; then
+ echo "❌ Unit tests failed"
+ exit 1
+ fi
+ echo "✅ Unit tests completed successfully"
+
+ - name: "Archive test results"
+ uses: actions/upload-artifact@v3
Review Comment:
like this ?
`
- name: "Archive test results"
uses: actions/upload-artifact@v4
with:
name: test-results
path: coverage.txt
retention-days: 7
overwrite: true
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight merged PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#issuecomment-3289515757
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.90083%` with `34 lines` in your changes missing coverage. Please review.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`master@d50ec63`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...mysql\_insertonduplicate\_update\_undo\_log\_builder.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fundo%2Fbuilder%2Fmysql_insertonduplicate_update_undo_log_builder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3VuZG8vYnVpbGRlci9teXNxbF9pbnNlcnRvbmR1cGxpY2F0ZV91cGRhdGVfdW5kb19sb2dfYnVpbGRlci5nbw==) | 74.35% | [23 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/types/image.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Ftypes%2Fimage.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3R5cGVzL2ltYWdlLmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #884 +/- ##
=========================================
Coverage ? 38.32%
=========================================
Files ? 188
Lines ? 11476
Branches ? 0
=========================================
Hits ? 4398
Misses ? 6647
Partials ? 431
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-seata-go/pull/884?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "lxfeng1997 (via GitHub)" <gi...@apache.org>.
lxfeng1997 commented on code in PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#discussion_r2405554147
##########
.github/workflows/unit-test.yml:
##########
@@ -0,0 +1,79 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: "Unit Test"
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ "*" ]
+ types: [opened, synchronize, reopened]
+
+permissions:
+ contents: read
+
+jobs:
+ unit-test:
+ name: Unit Test
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+ strategy:
+ matrix:
+ golang:
+ - 1.18
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "FinnTew (via GitHub)" <gi...@apache.org>.
FinnTew commented on code in PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#discussion_r2356077713
##########
.github/workflows/unit-test.yml:
##########
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: "Unit Test"
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ "*" ]
+ types: [opened, synchronize, reopened]
+
+permissions:
+ contents: read
+
+jobs:
+ unit-test:
+ name: Unit Test
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+ strategy:
+ matrix:
+ golang:
+ - 1.18
+
+ steps:
+ - name: "Set up Go"
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ matrix.golang }}
+
+ - name: "Checkout code"
+ uses: actions/checkout@v3
+ with:
+ submodules: true
+
+ - name: "Cache dependencies"
+ uses: actions/cache@v3
+ with:
+ path: ~/go/pkg/mod
+ key: "${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}"
+ restore-keys: |
+ "${{ runner.os }}-go-"
+
+ - name: Shutdown default mysql
+ run: sudo service mysql stop
+
+
+ - name: "Run Unit Tests"
+ run: |
+ echo "=== Starting Unit Tests ==="
+ go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic -timeout 10m
+ if [ $? -ne 0 ]; then
+ echo "❌ Unit tests failed"
+ exit 1
+ fi
+ echo "✅ Unit tests completed successfully"
+
+ - name: "Archive test results"
+ uses: actions/upload-artifact@v3
Review Comment:
In v4, Artifacts are immutable (unless deleted). So you must change each of the uploaded Artifacts to have a different name and filter the downloads by name to achieve the same effect:
```yaml
jobs:
upload:
strategy:
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.runs-on }}
steps:
- name: Create a File
run: echo "hello from ${{ matrix.runs-on }}" > file-${{ matrix.runs-on }}.txt
- name: Upload Artifact
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
- name: my-artifact
+ name: my-artifact-${{ matrix.runs-on }}
path: file-${{ matrix.runs-on }}.txt
```
---
Refer to the corresponding GitHub actions document (as above), the CI step related to `upload-artifact` needs to be modified, including version upgrades and some parameter changes.
Reference document: [https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) [incubator-seata-go]
Posted by "FinnTew (via GitHub)" <gi...@apache.org>.
FinnTew commented on code in PR #884:
URL: https://github.com/apache/incubator-seata-go/pull/884#discussion_r2363935948
##########
.github/workflows/unit-test.yml:
##########
@@ -0,0 +1,79 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: "Unit Test"
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ "*" ]
+ types: [opened, synchronize, reopened]
+
+permissions:
+ contents: read
+
+jobs:
+ unit-test:
+ name: Unit Test
+ runs-on: ubuntu-latest
+ timeout-minutes: 10
+ strategy:
+ matrix:
+ golang:
+ - 1.18
Review Comment:
The issue encountered in unit test CI:
```
../../../go/pkg/mod/go.uber.org/multierr@v1.10.0/error.go:224:20: undefined: atomic.Bool
```
This problem may be resolved by upgrading the Go version to 1.20.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org