[GitHub] betodealmeida commented on issue #6815: Make the target path of the superset logo configuable

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #6815: Make the target path of the superset logo configuable
URL: https://github.com/apache/incubator-superset/pull/6815#issuecomment-461129459
 
 
   LGTM, I would just add an entry in `config.py` or in the documentation describing the feature, so users are aware of the feature.
   
   Maybe add this to `config.py`:
   
   ```python
   # bla bla bla
   LOGO_TARGET_PATH = None
   ```
   
   And then update the template to:
   
   ```python
   logo_target_path = appbuilder.app.config.get('LOGO_TARGET_PATH') or '/profile/{}/'.format(current_user.username)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org