You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2026/05/25 06:19:55 UTC
[PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
englefly opened a new pull request, #63586:
URL: https://github.com/apache/doris/pull/63586
### What problem does this PR solve?
pick #62509
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4600134352
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4532020145
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4532018693
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4532306132
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63586:
URL: https://github.com/apache/doris/pull/63586#discussion_r3339721551
##########
regression-test/suites/nereids_p0/stats/partitionRowCount.groovy:
##########
@@ -35,7 +35,7 @@ suite("partitionRowCount") {
sql """physical plan
select * from partitionRowCountTable where a < 250;
"""
- contains("PhysicalOlapScan[partitionRowCountTable partitions(2/3)]@0 ( stats=4, operativeSlots=[a#0]")
+ contains("table=partitionRowCountTable partitions(2/3)")
}
Review Comment:
This weakens the regression test so it no longer checks the bug this suite is named for. Before this PR the assertion required `stats=4`; now it only verifies that two partitions are selected, so a regression in partition row-count estimation would still pass. Please keep the id-independent part of the new format but include the row count, for example by matching `table=partitionRowCountTable partitions(2/3), stats=4` or by adding a separate `contains("stats=4")` assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4602999212
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4602997672
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #63586:
URL: https://github.com/apache/doris/pull/63586#issuecomment-4600133337
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #63586:
URL: https://github.com/apache/doris/pull/63586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org