You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Vandahl (JIRA)" <ji...@apache.org> on 2007/04/22 19:41:15 UTC

[jira] Created: (TORQUE-91) Index-column size attribute is documented but does not work

Index-column size attribute is documented but does not work
-----------------------------------------------------------

                 Key: TORQUE-91
                 URL: https://issues.apache.org/jira/browse/TORQUE-91
             Project: Torque
          Issue Type: Bug
          Components: Generator
    Affects Versions: 3.3-RC2
            Reporter: Thomas Vandahl
            Priority: Minor


The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[jira] Resolved: (TORQUE-91) Index-column size attribute is documented but does not work

Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Fischer resolved TORQUE-91.
----------------------------------

    Fix Version/s: 4.0
       Resolution: Fixed

Resolved in the transition from database.dtd to database.xsd

> Index-column size attribute is documented but does not work
> -----------------------------------------------------------
>
>                 Key: TORQUE-91
>                 URL: https://issues.apache.org/jira/browse/TORQUE-91
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.3-RC2
>            Reporter: Thomas Vandahl
>            Priority: Minor
>             Fix For: 4.0
>
>
> The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[jira] Commented: (TORQUE-91) Index-column size attribute is documented but does not work

Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493921 ] 

Thomas Fischer commented on TORQUE-91:
--------------------------------------

If the size attribute is a quasi-standard, then we should keep it. A short glance at the postgresql and derby manuals suggest that it's not a quasi-standard, so 1) seems the correct way to go for me.

> Index-column size attribute is documented but does not work
> -----------------------------------------------------------
>
>                 Key: TORQUE-91
>                 URL: https://issues.apache.org/jira/browse/TORQUE-91
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.3-RC2
>            Reporter: Thomas Vandahl
>            Priority: Minor
>
> The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[jira] Commented: (TORQUE-91) Index-column size attribute is documented but does not work

Posted by "CG Monroe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490938 ] 

CG Monroe commented on TORQUE-91:
---------------------------------

I'm not sure I agree with the proposed resolution.  IMHO, the schema should be SQL standards / defacto standards based and not have any DB specific attributes.  (FWIW, it appears that CREATE INDEX is a defacto standard... I'd describe a defacto standard as one shown to be supported by most of  of DB servers Torque supports. )

With this in mind, the solution to this would seem to be:

1) Deprecate the size attribute (and remove it in 4.0?).

2) If this seems like a good feature to add into Torque,  add support for it via that option element which is intended to support DB Server specific items.

But for 2) we'd have to think about how to support / test these DB Specific items prior to release, how to document them, and how to deal with possible DB Vendor changes between versions.  So should this be Torque "core" or an "add-on"?

> Index-column size attribute is documented but does not work
> -----------------------------------------------------------
>
>                 Key: TORQUE-91
>                 URL: https://issues.apache.org/jira/browse/TORQUE-91
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.3-RC2
>            Reporter: Thomas Vandahl
>            Priority: Minor
>
> The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[jira] Commented: (TORQUE-91) Index-column size attribute is documented but does not work

Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534612 ] 

Thomas Fischer commented on TORQUE-91:
--------------------------------------

I added a note to the database dtd, the schema reference and the changes that the element is not used and will be removed in the future.
Leaving this issue open so we remember removing the attribute after 3.3 is out.

> Index-column size attribute is documented but does not work
> -----------------------------------------------------------
>
>                 Key: TORQUE-91
>                 URL: https://issues.apache.org/jira/browse/TORQUE-91
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.3-RC2
>            Reporter: Thomas Vandahl
>            Priority: Minor
>
> The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[jira] Commented: (TORQUE-91) Index-column size attribute is documented but does not work

Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490954 ] 

Thomas Vandahl commented on TORQUE-91:
--------------------------------------

I can live with 1), anytime. The point is, documented attributes/elements should work or the attribute including docs should be removed, there is no in between. I found that most of the databases I checked do not support limiting the size of an index column directly, everything else is vendor specific. So basically, +1 for removing said attribute from the schema.

> Index-column size attribute is documented but does not work
> -----------------------------------------------------------
>
>                 Key: TORQUE-91
>                 URL: https://issues.apache.org/jira/browse/TORQUE-91
>             Project: Torque
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 3.3-RC2
>            Reporter: Thomas Vandahl
>            Priority: Minor
>
> The database schema allows a "size" attribute for the "index-column" element which did not make it into neither the Index code nor the templates. Some databases support this parameter, however (namely MySQL). The attribute should be utilized where supported by the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org