You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2026/06/08 07:37:14 UTC
(causeway) 09/27: CAUSEWAY-4017: archives known action parameter export change

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch CAUSEWAY-4025
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit 32b71da96e96323539b10ebdbfac14439336cee5
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Jun 8 05:37:14 2026 +0100

    CAUSEWAY-4017: archives known action parameter export change
---
 .../.openspec.yaml                                 |  0
 .../design.md                                      |  0
 .../proposal.md                                    |  0
 .../specs/command-export-known-targets/spec.md     |  0
 .../tasks.md                                       |  0
 .../specs/command-export-known-targets/spec.md     | 55 ++++++++++++++++++++++
 6 files changed, 55 insertions(+)

diff --git a/openspec/changes/require-known-action-parameters/.openspec.yaml b/openspec/changes/archive/2026-06-08-require-known-action-parameters/.openspec.yaml
similarity index 100%
rename from openspec/changes/require-known-action-parameters/.openspec.yaml
rename to openspec/changes/archive/2026-06-08-require-known-action-parameters/.openspec.yaml
diff --git a/openspec/changes/require-known-action-parameters/design.md b/openspec/changes/archive/2026-06-08-require-known-action-parameters/design.md
similarity index 100%
rename from openspec/changes/require-known-action-parameters/design.md
rename to openspec/changes/archive/2026-06-08-require-known-action-parameters/design.md
diff --git a/openspec/changes/require-known-action-parameters/proposal.md b/openspec/changes/archive/2026-06-08-require-known-action-parameters/proposal.md
similarity index 100%
rename from openspec/changes/require-known-action-parameters/proposal.md
rename to openspec/changes/archive/2026-06-08-require-known-action-parameters/proposal.md
diff --git a/openspec/changes/require-known-action-parameters/specs/command-export-known-targets/spec.md b/openspec/changes/archive/2026-06-08-require-known-action-parameters/specs/command-export-known-targets/spec.md
similarity index 100%
rename from openspec/changes/require-known-action-parameters/specs/command-export-known-targets/spec.md
rename to openspec/changes/archive/2026-06-08-require-known-action-parameters/specs/command-export-known-targets/spec.md
diff --git a/openspec/changes/require-known-action-parameters/tasks.md b/openspec/changes/archive/2026-06-08-require-known-action-parameters/tasks.md
similarity index 100%
rename from openspec/changes/require-known-action-parameters/tasks.md
rename to openspec/changes/archive/2026-06-08-require-known-action-parameters/tasks.md
diff --git a/openspec/specs/command-export-known-targets/spec.md b/openspec/specs/command-export-known-targets/spec.md
index efef38e9dcd..c46dd7eacb2 100644
--- a/openspec/specs/command-export-known-targets/spec.md
+++ b/openspec/specs/command-export-known-targets/spec.md
@@ -84,3 +84,58 @@ A command before the export manager baseline MUST NOT make a target known for th
 - **AND** a command before the baseline has result bookmark `demoCustomer:1`
 - **WHEN** a selected later action command targets bookmark `demoCustomer:1`
 - **THEN** the export manager rejects the selected command unless another command at or after the baseline establishes `demoCustomer:1`
+
+### Requirement: Export validates known action reference parameters
+The export manager SHALL validate every selected action command reference parameter before creating export YAML.
+The export manager SHALL treat an action reference parameter as known only when the parameter bookmark is an export root or when the parameter bookmark was produced as the result of an earlier command in the baseline-bounded exportable sequence.
+If a selected action reference parameter is unknown, the export manager MUST prevent the export from occurring.
+The validation message SHALL identify the failing command, the reference parameter name, and the unknown parameter bookmark.
+The validation message SHALL indicate that a navigation or finder action returning the parameter object must be included earlier in the exportable sequence.
+The system MUST NOT block additional commands while recording merely because their reference parameters are not yet known.
+
+#### Scenario: Action with previously returned reference parameter is accepted for export
+- **GIVEN** an export manager baseline is set
+- **AND** an earlier command at or after the baseline has result bookmark `demoCustomer:1`
+- **AND** a selected later action command has reference parameter `customer` with bookmark `demoCustomer:1`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the system accepts the later command for export
+
+#### Scenario: Action with root service reference parameter is accepted for export
+- **GIVEN** an export manager has a selected action command with reference parameter `menu` whose bookmark identifies a menu service annotated with `@DomainService`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the system accepts the reference parameter as a root participant for the export sequence
+
+#### Scenario: Action with unknown reference parameter is rejected for export
+- **GIVEN** an export manager baseline is set
+- **AND** a selected action command has reference parameter `customer` with bookmark `demoCustomer:1`
+- **AND** the parameter bookmark `demoCustomer:1` is not a menu service root
+- **AND** no earlier command at or after the baseline has result bookmark `demoCustomer:1`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the system prevents the export from occurring
+- **AND** the validation message identifies the selected command, parameter `customer`, and bookmark `demoCustomer:1`
+
+#### Scenario: Later result does not validate earlier reference parameter
+- **GIVEN** an export manager baseline is set
+- **AND** a selected action command has reference parameter `customer` with bookmark `demoCustomer:1`
+- **AND** a later selected command in export order has result bookmark `demoCustomer:1`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the system rejects the earlier selected command because the parameter was not known at that point in the export sequence
+
+#### Scenario: Result before baseline does not validate selected reference parameter
+- **GIVEN** an export manager baseline is set
+- **AND** a command before the baseline has result bookmark `demoCustomer:1`
+- **AND** a selected later action command has reference parameter `customer` with bookmark `demoCustomer:1`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the export manager rejects the selected command unless another command at or after the baseline establishes `demoCustomer:1`
+
+#### Scenario: Recording is not blocked by unknown reference parameter
+- **GIVEN** command-log recording support is `ENABLED`
+- **AND** no earlier command has result bookmark `demoCustomer:1`
+- **WHEN** a user invokes an action command with reference parameter `customer` set to bookmark `demoCustomer:1`
+- **THEN** the system does not reject the action merely because command export might later find the parameter unknown
+
+#### Scenario: Non-reference parameters are not export path participants
+- **GIVEN** an export manager baseline is set
+- **AND** a selected action command has scalar parameter `name` with value `Alice`
+- **WHEN** the export manager validates the selected command sequence
+- **THEN** the scalar parameter does not need to be known as an export target