You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2012/07/27 15:38:24 UTC
Re: [6/11] AutoScale changes in Apache master
Pranav:
A couple of issues:
The commit contained an author statement, this is generally bad form,
and unmaintainable. Moreover, the git log should show who the author
is. (and I just saw a commit fixing that, thanks for taking care of
it.)
But this also suggests that the author isn't you, and I don't recall
having seen this come through as a patch request. We have a processes
for getting code into CloudStack and none of them involve a
non-transparent back channel. This does a disservice to the original
author (people aren't seeing patches from him, which impedes his path
to becoming a committer) as well as casting doubts over the provenance
of the code. All three of the commits appear to have authors that
aren't you, did this code come in as a patch to the mailing list,
reviews.a.o, or the bug tracker?
--David
> +/**
> + * @author Deepak Garg
> + */
> +
RE: [6/11] AutoScale changes in Apache master
Posted by Ram Ganesh <Ra...@citrix.com>.
Sure. Will do.
Thanks,
Ram
> -----Original Message-----
> From: sebgoa [mailto:runseb@gmail.com]
> Sent: 01 August 2012 22:14
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [6/11] AutoScale changes in Apache master
>
> Let us know when you revisit. When I quickly read your spec it seemed
> that it would be fairly straightforward to enable some of the
> autoscaling api documented at:
>
> http://docs.amazonwebservices.com/AutoScaling/latest/APIReference/Welco
> me.html?r=8301
>
> -Sebastien
>
> On Aug 1, 2012, at 10:15 AM, Ram Ganesh wrote:
>
> > Makes sense Sebastien. Currently we are in the final leg of AutoScale
> feature implementation. We can revisit this topic some time soon. Also
> we had some prior discussions on this feature to be more vendor-
> agnostic.
> >
> > Thanks,
> > Ram
> >
> >
> >> -----Original Message-----
> >> From: sebgoa [mailto:runseb@gmail.com]
> >> Sent: 31 July 2012 22:00
> >> To: cloudstack-dev@incubator.apache.org
> >> Subject: Re: [6/11] AutoScale changes in Apache master
> >>
> >> Hi Vijay, are you also developing the corresponding ec2 auto-scale
> api
> >> implementation ?
> >>
> >> It would be nice if everytime a new feature is developed the
> >> corresponding aws api (if it exsits) is also implemented at the same
> >> time.
> >>
> >> -Sebastien
> >>
> >> On Jul 27, 2012, at 11:17 AM, Vijay Venkatachalam wrote:
> >>
> >>> Hi,
> >>>
> >>> In the next official CloudStack Citrix release, one of the features
> >>> is AutoScale. The feature development is still going on and we have
> >>> created a topic branch in asf. At the current stage
> >>> there are no unit tests, these will be added very soon.
> >>>
> >>> Pranav has helped us create a topic branch out of asf/master and we
> >> have
> >>> called it "autoscale". Any enhancement or bugs addressed
> >>> for this feature will be sent as a patch hence forth.
> >>>
> >>> So, the feature is ready for viewing in asf/autoscale branch. It
> >> would be great to
> >>> see some activity in terms of code review/ suggestions/enhancement
> on
> >> autoscale.
> >>>
> >>>
> >>> The spec for AutoScale feature was earlier discussed in the dev
> >> mailing list,
> >>> I am attaching one of the threads for reference.
> >>>
> >>> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-
> >>
> dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILB
> >> OX01.citrite.net%3E
> >>>
> >>>
> >>> Here is the related functional spec:
> >>>
> >>> http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
> >>>
> >>>
> >>>
> >>> Thank you,
> >>> -Vijay.
> >>>
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Pranav Saxena
> >>>> Sent: Friday, July 27, 2012 7:34 PM
> >>>> To: cloudstack-dev@incubator.apache.org; David Nalley
> >> (david@gnsa.us)
> >>>> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
> >>>> Subject: RE: [6/11] AutoScale changes in Apache master
> >>>>
> >>>> Hi David,
> >>>>
> >>>> This commit was based on addition of a new feature called
> AutoScale
> >> on
> >>>> which few guys from Bangalore have been working on , including me
> .
> >> Since
> >>>> this feature was supposed to be pushed in today , so we had to
> >> create a new
> >>>> branch asf/autoscale ( pulled out of 3.0.x - citrix private
> branch
> >> ) and push
> >>>> the changes there. This was as per Alena's request that I should
> >> proceed by
> >>>> pushing the changes for the Autoscale feature (since I am the only
> >> committer
> >>>> here in Bangalore) by creating a new branch on apache and the
> >> author(
> >>>> Vijay) would send out an email on the cloudstack dev list ,
> >> mentioning about
> >>>> the Autoscale feature. We'll be merging some more changes very
> soon.
> >>>>
> >>>> @Vijay - could you please elaborate on the Autoscale feature ?
> >>>>
> >>>> Thanks & Regards,
> >>>> Pranav
> >>>>
> >>>> -----Original Message-----
> >>>> From: David Nalley [mailto:david@gnsa.us]
> >>>> Sent: Friday, July 27, 2012 7:08 PM
> >>>> To: cloudstack-dev@incubator.apache.org
> >>>> Subject: Re: [6/11] AutoScale changes in Apache master
> >>>>
> >>>> Pranav:
> >>>>
> >>>> A couple of issues:
> >>>>
> >>>> The commit contained an author statement, this is generally bad
> >> form, and
> >>>> unmaintainable. Moreover, the git log should show who the author
> is.
> >> (and I
> >>>> just saw a commit fixing that, thanks for taking care of
> >>>> it.)
> >>>>
> >>>> But this also suggests that the author isn't you, and I don't
> recall
> >> having seen
> >>>> this come through as a patch request. We have a processes for
> >> getting code
> >>>> into CloudStack and none of them involve a non-transparent back
> >> channel.
> >>>> This does a disservice to the original author (people aren't
> seeing
> >> patches
> >>>> from him, which impedes his path to becoming a committer) as well
> as
> >>>> casting doubts over the provenance of the code. All three of the
> >> commits
> >>>> appear to have authors that aren't you, did this code come in as a
> >> patch to
> >>>> the mailing list, reviews.a.o, or the bug tracker?
> >>>>
> >>>> --David
> >>>>
> >>>>> +/**
> >>>>> + * @author Deepak Garg
> >>>>> + */
> >>>>> +
> >
Re: [6/11] AutoScale changes in Apache master
Posted by sebgoa <ru...@gmail.com>.
Let us know when you revisit. When I quickly read your spec it seemed that it would be fairly straightforward to enable some of the autoscaling api documented at:
http://docs.amazonwebservices.com/AutoScaling/latest/APIReference/Welcome.html?r=8301
-Sebastien
On Aug 1, 2012, at 10:15 AM, Ram Ganesh wrote:
> Makes sense Sebastien. Currently we are in the final leg of AutoScale feature implementation. We can revisit this topic some time soon. Also we had some prior discussions on this feature to be more vendor-agnostic.
>
> Thanks,
> Ram
>
>
>> -----Original Message-----
>> From: sebgoa [mailto:runseb@gmail.com]
>> Sent: 31 July 2012 22:00
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: [6/11] AutoScale changes in Apache master
>>
>> Hi Vijay, are you also developing the corresponding ec2 auto-scale api
>> implementation ?
>>
>> It would be nice if everytime a new feature is developed the
>> corresponding aws api (if it exsits) is also implemented at the same
>> time.
>>
>> -Sebastien
>>
>> On Jul 27, 2012, at 11:17 AM, Vijay Venkatachalam wrote:
>>
>>> Hi,
>>>
>>> In the next official CloudStack Citrix release, one of the features
>>> is AutoScale. The feature development is still going on and we have
>>> created a topic branch in asf. At the current stage
>>> there are no unit tests, these will be added very soon.
>>>
>>> Pranav has helped us create a topic branch out of asf/master and we
>> have
>>> called it "autoscale". Any enhancement or bugs addressed
>>> for this feature will be sent as a patch hence forth.
>>>
>>> So, the feature is ready for viewing in asf/autoscale branch. It
>> would be great to
>>> see some activity in terms of code review/ suggestions/enhancement on
>> autoscale.
>>>
>>>
>>> The spec for AutoScale feature was earlier discussed in the dev
>> mailing list,
>>> I am attaching one of the threads for reference.
>>>
>>> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-
>> dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILB
>> OX01.citrite.net%3E
>>>
>>>
>>> Here is the related functional spec:
>>>
>>> http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
>>>
>>>
>>>
>>> Thank you,
>>> -Vijay.
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Pranav Saxena
>>>> Sent: Friday, July 27, 2012 7:34 PM
>>>> To: cloudstack-dev@incubator.apache.org; David Nalley
>> (david@gnsa.us)
>>>> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
>>>> Subject: RE: [6/11] AutoScale changes in Apache master
>>>>
>>>> Hi David,
>>>>
>>>> This commit was based on addition of a new feature called AutoScale
>> on
>>>> which few guys from Bangalore have been working on , including me .
>> Since
>>>> this feature was supposed to be pushed in today , so we had to
>> create a new
>>>> branch asf/autoscale ( pulled out of 3.0.x - citrix private branch
>> ) and push
>>>> the changes there. This was as per Alena's request that I should
>> proceed by
>>>> pushing the changes for the Autoscale feature (since I am the only
>> committer
>>>> here in Bangalore) by creating a new branch on apache and the
>> author(
>>>> Vijay) would send out an email on the cloudstack dev list ,
>> mentioning about
>>>> the Autoscale feature. We'll be merging some more changes very soon.
>>>>
>>>> @Vijay - could you please elaborate on the Autoscale feature ?
>>>>
>>>> Thanks & Regards,
>>>> Pranav
>>>>
>>>> -----Original Message-----
>>>> From: David Nalley [mailto:david@gnsa.us]
>>>> Sent: Friday, July 27, 2012 7:08 PM
>>>> To: cloudstack-dev@incubator.apache.org
>>>> Subject: Re: [6/11] AutoScale changes in Apache master
>>>>
>>>> Pranav:
>>>>
>>>> A couple of issues:
>>>>
>>>> The commit contained an author statement, this is generally bad
>> form, and
>>>> unmaintainable. Moreover, the git log should show who the author is.
>> (and I
>>>> just saw a commit fixing that, thanks for taking care of
>>>> it.)
>>>>
>>>> But this also suggests that the author isn't you, and I don't recall
>> having seen
>>>> this come through as a patch request. We have a processes for
>> getting code
>>>> into CloudStack and none of them involve a non-transparent back
>> channel.
>>>> This does a disservice to the original author (people aren't seeing
>> patches
>>>> from him, which impedes his path to becoming a committer) as well as
>>>> casting doubts over the provenance of the code. All three of the
>> commits
>>>> appear to have authors that aren't you, did this code come in as a
>> patch to
>>>> the mailing list, reviews.a.o, or the bug tracker?
>>>>
>>>> --David
>>>>
>>>>> +/**
>>>>> + * @author Deepak Garg
>>>>> + */
>>>>> +
>
RE: [6/11] AutoScale changes in Apache master
Posted by Ram Ganesh <Ra...@citrix.com>.
Makes sense Sebastien. Currently we are in the final leg of AutoScale feature implementation. We can revisit this topic some time soon. Also we had some prior discussions on this feature to be more vendor-agnostic.
Thanks,
Ram
> -----Original Message-----
> From: sebgoa [mailto:runseb@gmail.com]
> Sent: 31 July 2012 22:00
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [6/11] AutoScale changes in Apache master
>
> Hi Vijay, are you also developing the corresponding ec2 auto-scale api
> implementation ?
>
> It would be nice if everytime a new feature is developed the
> corresponding aws api (if it exsits) is also implemented at the same
> time.
>
> -Sebastien
>
> On Jul 27, 2012, at 11:17 AM, Vijay Venkatachalam wrote:
>
> > Hi,
> >
> > In the next official CloudStack Citrix release, one of the features
> > is AutoScale. The feature development is still going on and we have
> > created a topic branch in asf. At the current stage
> > there are no unit tests, these will be added very soon.
> >
> > Pranav has helped us create a topic branch out of asf/master and we
> have
> > called it "autoscale". Any enhancement or bugs addressed
> > for this feature will be sent as a patch hence forth.
> >
> > So, the feature is ready for viewing in asf/autoscale branch. It
> would be great to
> > see some activity in terms of code review/ suggestions/enhancement on
> autoscale.
> >
> >
> > The spec for AutoScale feature was earlier discussed in the dev
> mailing list,
> > I am attaching one of the threads for reference.
> >
> > http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-
> dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILB
> OX01.citrite.net%3E
> >
> >
> > Here is the related functional spec:
> >
> > http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
> >
> >
> >
> > Thank you,
> > -Vijay.
> >
> >
> >
> >> -----Original Message-----
> >> From: Pranav Saxena
> >> Sent: Friday, July 27, 2012 7:34 PM
> >> To: cloudstack-dev@incubator.apache.org; David Nalley
> (david@gnsa.us)
> >> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
> >> Subject: RE: [6/11] AutoScale changes in Apache master
> >>
> >> Hi David,
> >>
> >> This commit was based on addition of a new feature called AutoScale
> on
> >> which few guys from Bangalore have been working on , including me .
> Since
> >> this feature was supposed to be pushed in today , so we had to
> create a new
> >> branch asf/autoscale ( pulled out of 3.0.x - citrix private branch
> ) and push
> >> the changes there. This was as per Alena's request that I should
> proceed by
> >> pushing the changes for the Autoscale feature (since I am the only
> committer
> >> here in Bangalore) by creating a new branch on apache and the
> author(
> >> Vijay) would send out an email on the cloudstack dev list ,
> mentioning about
> >> the Autoscale feature. We'll be merging some more changes very soon.
> >>
> >> @Vijay - could you please elaborate on the Autoscale feature ?
> >>
> >> Thanks & Regards,
> >> Pranav
> >>
> >> -----Original Message-----
> >> From: David Nalley [mailto:david@gnsa.us]
> >> Sent: Friday, July 27, 2012 7:08 PM
> >> To: cloudstack-dev@incubator.apache.org
> >> Subject: Re: [6/11] AutoScale changes in Apache master
> >>
> >> Pranav:
> >>
> >> A couple of issues:
> >>
> >> The commit contained an author statement, this is generally bad
> form, and
> >> unmaintainable. Moreover, the git log should show who the author is.
> (and I
> >> just saw a commit fixing that, thanks for taking care of
> >> it.)
> >>
> >> But this also suggests that the author isn't you, and I don't recall
> having seen
> >> this come through as a patch request. We have a processes for
> getting code
> >> into CloudStack and none of them involve a non-transparent back
> channel.
> >> This does a disservice to the original author (people aren't seeing
> patches
> >> from him, which impedes his path to becoming a committer) as well as
> >> casting doubts over the provenance of the code. All three of the
> commits
> >> appear to have authors that aren't you, did this code come in as a
> patch to
> >> the mailing list, reviews.a.o, or the bug tracker?
> >>
> >> --David
> >>
> >>> +/**
> >>> + * @author Deepak Garg
> >>> + */
> >>> +
Re: [6/11] AutoScale changes in Apache master
Posted by sebgoa <ru...@gmail.com>.
Hi Vijay, are you also developing the corresponding ec2 auto-scale api implementation ?
It would be nice if everytime a new feature is developed the corresponding aws api (if it exsits) is also implemented at the same time.
-Sebastien
On Jul 27, 2012, at 11:17 AM, Vijay Venkatachalam wrote:
> Hi,
>
> In the next official CloudStack Citrix release, one of the features
> is AutoScale. The feature development is still going on and we have
> created a topic branch in asf. At the current stage
> there are no unit tests, these will be added very soon.
>
> Pranav has helped us create a topic branch out of asf/master and we have
> called it "autoscale". Any enhancement or bugs addressed
> for this feature will be sent as a patch hence forth.
>
> So, the feature is ready for viewing in asf/autoscale branch. It would be great to
> see some activity in terms of code review/ suggestions/enhancement on autoscale.
>
>
> The spec for AutoScale feature was earlier discussed in the dev mailing list,
> I am attaching one of the threads for reference.
>
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILBOX01.citrite.net%3E
>
>
> Here is the related functional spec:
>
> http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
>
>
>
> Thank you,
> -Vijay.
>
>
>
>> -----Original Message-----
>> From: Pranav Saxena
>> Sent: Friday, July 27, 2012 7:34 PM
>> To: cloudstack-dev@incubator.apache.org; David Nalley (david@gnsa.us)
>> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
>> Subject: RE: [6/11] AutoScale changes in Apache master
>>
>> Hi David,
>>
>> This commit was based on addition of a new feature called AutoScale on
>> which few guys from Bangalore have been working on , including me . Since
>> this feature was supposed to be pushed in today , so we had to create a new
>> branch asf/autoscale ( pulled out of 3.0.x - citrix private branch ) and push
>> the changes there. This was as per Alena's request that I should proceed by
>> pushing the changes for the Autoscale feature (since I am the only committer
>> here in Bangalore) by creating a new branch on apache and the author(
>> Vijay) would send out an email on the cloudstack dev list , mentioning about
>> the Autoscale feature. We'll be merging some more changes very soon.
>>
>> @Vijay - could you please elaborate on the Autoscale feature ?
>>
>> Thanks & Regards,
>> Pranav
>>
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Friday, July 27, 2012 7:08 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: [6/11] AutoScale changes in Apache master
>>
>> Pranav:
>>
>> A couple of issues:
>>
>> The commit contained an author statement, this is generally bad form, and
>> unmaintainable. Moreover, the git log should show who the author is. (and I
>> just saw a commit fixing that, thanks for taking care of
>> it.)
>>
>> But this also suggests that the author isn't you, and I don't recall having seen
>> this come through as a patch request. We have a processes for getting code
>> into CloudStack and none of them involve a non-transparent back channel.
>> This does a disservice to the original author (people aren't seeing patches
>> from him, which impedes his path to becoming a committer) as well as
>> casting doubts over the provenance of the code. All three of the commits
>> appear to have authors that aren't you, did this code come in as a patch to
>> the mailing list, reviews.a.o, or the bug tracker?
>>
>> --David
>>
>>> +/**
>>> + * @author Deepak Garg
>>> + */
>>> +
RE: [6/11] AutoScale changes in Apache master
Posted by Deepak Garg <de...@citrix.com>.
HI,
Apologies for not sending out an email about the new branch early on.
Here is the wiki link of the FS: http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
which was discussed a few days before in the ML.
We will be sending the fixes in patches on the ML for review and discussion.
Thanks,
Deepak
-----Original Message-----
From: Vijay Venkatachalam [mailto:Vijay.Venkatachalam@citrix.com]
Sent: Friday, July 27, 2012 8:47 PM
To: cloudstack-dev@incubator.apache.org; David Nalley (david@gnsa.us); Pranav Saxena
Subject: RE: [6/11] AutoScale changes in Apache master
Hi,
In the next official CloudStack Citrix release, one of the features
is AutoScale. The feature development is still going on and we have
created a topic branch in asf. At the current stage
there are no unit tests, these will be added very soon.
Pranav has helped us create a topic branch out of asf/master and we have
called it "autoscale". Any enhancement or bugs addressed
for this feature will be sent as a patch hence forth.
So, the feature is ready for viewing in asf/autoscale branch. It would be great to
see some activity in terms of code review/ suggestions/enhancement on autoscale.
The spec for AutoScale feature was earlier discussed in the dev mailing list,
I am attaching one of the threads for reference.
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILBOX01.citrite.net%3E
Here is the related functional spec:
http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
Thank you,
-Vijay.
> -----Original Message-----
> From: Pranav Saxena
> Sent: Friday, July 27, 2012 7:34 PM
> To: cloudstack-dev@incubator.apache.org; David Nalley (david@gnsa.us)
> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
> Subject: RE: [6/11] AutoScale changes in Apache master
>
> Hi David,
>
> This commit was based on addition of a new feature called AutoScale on
> which few guys from Bangalore have been working on , including me . Since
> this feature was supposed to be pushed in today , so we had to create a new
> branch asf/autoscale ( pulled out of 3.0.x - citrix private branch ) and push
> the changes there. This was as per Alena's request that I should proceed by
> pushing the changes for the Autoscale feature (since I am the only committer
> here in Bangalore) by creating a new branch on apache and the author(
> Vijay) would send out an email on the cloudstack dev list , mentioning about
> the Autoscale feature. We'll be merging some more changes very soon.
>
> @Vijay - could you please elaborate on the Autoscale feature ?
>
> Thanks & Regards,
> Pranav
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, July 27, 2012 7:08 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [6/11] AutoScale changes in Apache master
>
> Pranav:
>
> A couple of issues:
>
> The commit contained an author statement, this is generally bad form, and
> unmaintainable. Moreover, the git log should show who the author is. (and I
> just saw a commit fixing that, thanks for taking care of
> it.)
>
> But this also suggests that the author isn't you, and I don't recall having seen
> this come through as a patch request. We have a processes for getting code
> into CloudStack and none of them involve a non-transparent back channel.
> This does a disservice to the original author (people aren't seeing patches
> from him, which impedes his path to becoming a committer) as well as
> casting doubts over the provenance of the code. All three of the commits
> appear to have authors that aren't you, did this code come in as a patch to
> the mailing list, reviews.a.o, or the bug tracker?
>
> --David
>
> > +/**
> > + * @author Deepak Garg
> > + */
> > +
RE: [6/11] AutoScale changes in Apache master
Posted by Vijay Venkatachalam <Vi...@citrix.com>.
Hi,
In the next official CloudStack Citrix release, one of the features
is AutoScale. The feature development is still going on and we have
created a topic branch in asf. At the current stage
there are no unit tests, these will be added very soon.
Pranav has helped us create a topic branch out of asf/master and we have
called it "autoscale". Any enhancement or bugs addressed
for this feature will be sent as a patch hence forth.
So, the feature is ready for viewing in asf/autoscale branch. It would be great to
see some activity in terms of code review/ suggestions/enhancement on autoscale.
The spec for AutoScale feature was earlier discussed in the dev mailing list,
I am attaching one of the threads for reference.
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILBOX01.citrite.net%3E
Here is the related functional spec:
http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
Thank you,
-Vijay.
> -----Original Message-----
> From: Pranav Saxena
> Sent: Friday, July 27, 2012 7:34 PM
> To: cloudstack-dev@incubator.apache.org; David Nalley (david@gnsa.us)
> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
> Subject: RE: [6/11] AutoScale changes in Apache master
>
> Hi David,
>
> This commit was based on addition of a new feature called AutoScale on
> which few guys from Bangalore have been working on , including me . Since
> this feature was supposed to be pushed in today , so we had to create a new
> branch asf/autoscale ( pulled out of 3.0.x - citrix private branch ) and push
> the changes there. This was as per Alena's request that I should proceed by
> pushing the changes for the Autoscale feature (since I am the only committer
> here in Bangalore) by creating a new branch on apache and the author(
> Vijay) would send out an email on the cloudstack dev list , mentioning about
> the Autoscale feature. We'll be merging some more changes very soon.
>
> @Vijay - could you please elaborate on the Autoscale feature ?
>
> Thanks & Regards,
> Pranav
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, July 27, 2012 7:08 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [6/11] AutoScale changes in Apache master
>
> Pranav:
>
> A couple of issues:
>
> The commit contained an author statement, this is generally bad form, and
> unmaintainable. Moreover, the git log should show who the author is. (and I
> just saw a commit fixing that, thanks for taking care of
> it.)
>
> But this also suggests that the author isn't you, and I don't recall having seen
> this come through as a patch request. We have a processes for getting code
> into CloudStack and none of them involve a non-transparent back channel.
> This does a disservice to the original author (people aren't seeing patches
> from him, which impedes his path to becoming a committer) as well as
> casting doubts over the provenance of the code. All three of the commits
> appear to have authors that aren't you, did this code come in as a patch to
> the mailing list, reviews.a.o, or the bug tracker?
>
> --David
>
> > +/**
> > + * @author Deepak Garg
> > + */
> > +
RE: [6/11] AutoScale changes in Apache master
Posted by Pranav Saxena <pr...@citrix.com>.
Hi David,
This commit was based on addition of a new feature called AutoScale on which few guys from Bangalore have been working on , including me . Since this feature was supposed to be pushed in today , so we had to create a new branch asf/autoscale ( pulled out of 3.0.x - citrix private branch ) and push the changes there. This was as per Alena's request that I should proceed by pushing the changes for the Autoscale feature (since I am the only committer here in Bangalore) by creating a new branch on apache and the author( Vijay) would send out an email on the cloudstack dev list , mentioning about the Autoscale feature. We'll be merging some more changes very soon.
@Vijay - could you please elaborate on the Autoscale feature ?
Thanks & Regards,
Pranav
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Friday, July 27, 2012 7:08 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: [6/11] AutoScale changes in Apache master
Pranav:
A couple of issues:
The commit contained an author statement, this is generally bad form, and unmaintainable. Moreover, the git log should show who the author is. (and I just saw a commit fixing that, thanks for taking care of
it.)
But this also suggests that the author isn't you, and I don't recall having seen this come through as a patch request. We have a processes for getting code into CloudStack and none of them involve a non-transparent back channel. This does a disservice to the original author (people aren't seeing patches from him, which impedes his path to becoming a committer) as well as casting doubts over the provenance of the code. All three of the commits appear to have authors that aren't you, did this code come in as a patch to the mailing list, reviews.a.o, or the bug tracker?
--David
> +/**
> + * @author Deepak Garg
> + */
> +