You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/06/07 23:59:15 UTC

svn commit: r1490850 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java

Author: sebb
Date: Fri Jun  7 21:59:15 2013
New Revision: 1490850

URL: http://svn.apache.org/r1490850
Log:
NET-509 AuthenticatingSMTPClient needs a constructor with the isImplicit argument for SSL

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490850&r1=1490849&r2=1490850&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml [utf-8] (original)
+++ commons/proper/net/trunk/src/changes/changes.xml [utf-8] Fri Jun  7 21:59:15 2013
@@ -63,8 +63,11 @@ The <action> type attribute can be add,u
 
     <body>
         <release version="3.3" date="2013-06-??" description="
-This is a bug-fix release. See further details below.
+This is mainly a bug-fix release. See further details below.
         ">
+            <action issue="NET-509" dev="sebb" due-to="Anthony Dahanne" type="update">
+            AuthenticatingSMTPClient needs a constructor with the isImplicit argument for SSL
+            </action>
             <action issue="NET-501" dev="sebb"  due-to="Julián Lastiri" type="fix">
             Race Condition on TelnetClient.disconnect() and TelnetInputStream.run()
             java.lang.IllegalStateException: Queue is full! Cannot process another character. 

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java?rev=1490850&r1=1490849&r2=1490850&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java Fri Jun  7 21:59:15 2013
@@ -24,6 +24,7 @@ import java.security.NoSuchAlgorithmExce
 import java.security.spec.InvalidKeySpecException;
 import javax.crypto.Mac;
 import javax.crypto.spec.SecretKeySpec;
+import javax.net.ssl.SSLContext;
 
 import org.apache.commons.net.util.Base64;
 
@@ -56,6 +57,40 @@ public class AuthenticatingSMTPClient ex
     }
 
     /**
+     * Overloaded constructor that takes a protocol specification and the implicit argument
+     * @param proto the protocol.
+     * @param implicit The security mode, {@code true} for implicit, {@code false} for explicit
+     * @since 3.3
+     */
+    public AuthenticatingSMTPClient(String proto, boolean implicit)
+    {
+      super(proto, implicit);
+    }
+
+    /**
+     * Overloaded constructor that takes the protocol specification, the implicit argument and encoding
+     * @param proto the protocol.
+     * @param implicit The security mode, {@code true} for implicit, {@code false} for explicit
+     * @param encoding the encoding
+     * @since 3.3
+     */
+    public AuthenticatingSMTPClient(String proto, boolean implicit, String encoding)
+    {
+      super(proto, implicit, encoding);
+    }
+
+    /**
+     * Overloaded constructor that takes the implicit argument, and using {@link #DEFAULT_PROTOCOL} i.e. TLS
+     * @param implicit The security mode, {@code true} for implicit, {@code false} for explicit
+     * @param ctx A pre-configured SSL Context.
+     * @since 3.3
+     */
+    public AuthenticatingSMTPClient(boolean implicit, SSLContext ctx)
+    {
+      super(implicit, ctx);
+    }
+
+    /**
      * Overloaded constructor that takes a protocol specification and encoding
      * @param protocol The protocol to use
      * @param encoding The encoding to use