[GitHub] spark pull request #15638: [SPARK-18110][PYTHON][ML] add missing parameter i...

[wangmiao1981 <gi...@git.apache.org>]

Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15638#discussion_r85051149
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -828,7 +828,7 @@ def featureImportances(self):
     @inherit_doc
     class RandomForestRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasSeed,
                                 RandomForestParams, TreeRegressorParams, HasCheckpointInterval,
    -                            JavaMLWritable, JavaMLReadable):
    +                            JavaMLWritable, JavaMLReadable, HasVarianceCol):
    --- End diff --
    
    Would you like to group all the `Has*` parameters? Just a minor comment on the style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org