[GitHub] [spark] sujith71955 commented on a change in pull request #24315: [SPARK-274034][SQL] Table Statisics shall be updated automatically if auto size update feature is enabled(spark.sql.statistics.size.autoUpdate.enabled =true)

[GitBox <gi...@apache.org>]

sujith71955 commented on a change in pull request #24315: [SPARK-274034][SQL] Table Statisics shall be updated automatically if auto size update feature is enabled(spark.sql.statistics.size.autoUpdate.enabled =true)
URL: https://github.com/apache/spark/pull/24315#discussion_r272848362
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
 ##########
 @@ -42,16 +42,14 @@ object CommandUtils extends Logging {
 
   /** Change statistics after changing data by commands. */
   def updateTableStats(sparkSession: SparkSession, table: CatalogTable): Unit = {
-    if (table.stats.nonEmpty) {
 
 Review comment:
   Because of this condition check, the insert table command will never able to calculate the table size even if user enables sparkSession.sessionState.conf.autoSizeUpdateEnabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org