You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/09/28 00:18:17 UTC
Review Request 52324: GEODE-1941: delete unimplemented tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52324/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, Jared Stewart, Kevin Duling, and Udo Kohlmeyer.
Bugs: GEODE-1941
https://issues.apache.org/jira/browse/GEODE-1941
Repository: geode
Description
-------
GEODE-1941: delete unimplemented tests
This does not complete ticket GEODE-1941. It will remain open until
the unimplemented tests are created or are determined to not be
valuable.
Diffs
-----
geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorFactoryJUnitTest.java b9faff0
Diff: https://reviews.apache.org/r/52324/diff/
Testing
-------
SocketCreatorFactoryJUnitTest
precheckin
Thanks,
Kirk Lund
Re: Review Request 52324: GEODE-1941: delete unimplemented tests
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52324/#review150657
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Sept. 27, 2016, 5:18 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52324/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2016, 5:18 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, Jared Stewart, Kevin Duling, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1941
> https://issues.apache.org/jira/browse/GEODE-1941
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1941: delete unimplemented tests
>
> This does not complete ticket GEODE-1941. It will remain open until
> the unimplemented tests are created or are determined to not be
> valuable.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorFactoryJUnitTest.java b9faff0
>
> Diff: https://reviews.apache.org/r/52324/diff/
>
>
> Testing
> -------
>
> SocketCreatorFactoryJUnitTest
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 52324: GEODE-1941: delete unimplemented tests
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On Sept. 28, 2016, 2:03 a.m., Udo Kohlmeyer wrote:
> > Ship It!
These tests are valuable... They needed to be completed. I'll complete them.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52324/#review150666
-----------------------------------------------------------
On Sept. 28, 2016, 12:18 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52324/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 12:18 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, Jared Stewart, Kevin Duling, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1941
> https://issues.apache.org/jira/browse/GEODE-1941
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1941: delete unimplemented tests
>
> This does not complete ticket GEODE-1941. It will remain open until
> the unimplemented tests are created or are determined to not be
> valuable.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorFactoryJUnitTest.java b9faff0
>
> Diff: https://reviews.apache.org/r/52324/diff/
>
>
> Testing
> -------
>
> SocketCreatorFactoryJUnitTest
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 52324: GEODE-1941: delete unimplemented tests
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52324/#review150666
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On Sept. 28, 2016, 12:18 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52324/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 12:18 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, Jared Stewart, Kevin Duling, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1941
> https://issues.apache.org/jira/browse/GEODE-1941
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1941: delete unimplemented tests
>
> This does not complete ticket GEODE-1941. It will remain open until
> the unimplemented tests are created or are determined to not be
> valuable.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorFactoryJUnitTest.java b9faff0
>
> Diff: https://reviews.apache.org/r/52324/diff/
>
>
> Testing
> -------
>
> SocketCreatorFactoryJUnitTest
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>