You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/03/12 19:56:24 UTC
svn commit: r385344 -
/jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java
Author: sebb
Date: Sun Mar 12 10:56:23 2006
New Revision: 385344
URL: http://svn.apache.org/viewcvs?rev=385344&view=rev
Log:
Document some Findbugs info
Modified:
jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java
Modified: jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java?rev=385344&r1=385343&r2=385344&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java Sun Mar 12 10:56:23 2006
@@ -151,8 +151,7 @@
}
for (int idx = 0; idx < ports.getLength(); idx++) {
Element pnode = (Element) ports.item(idx);
- String portname = pnode.getAttribute("name");// TODO - why
- // not used?
+ // NOTUSED String portname = pnode.getAttribute("name");
// used to check binding, but now it doesn't. it was
// failing when wsdl did not using binding as expected
NodeList servlist = pnode.getElementsByTagName("soap:address");
@@ -369,7 +368,9 @@
// if the first child is soap:operation
// we add it to the array
Element child = (Element) opnodes.item(idz);
- NodeList soapnode = child.getElementsByTagName(soapOp);
+
+ // TODO - the following code looks wrong - it does the same in both cases
+ NodeList soapnode = child.getElementsByTagName(soapOp);
if (soapnode.getLength() > 0) {
ops.add(child);
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org